refactor(pure_pursuit): prefix package and namespace with autoware_ #7301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulfaqar-azmi-t4
requested review from
TakaHoribe and
takayuki5168
as code owners
zulfaqar-azmi-t4
changed the title
github-actions
bot
added
type:documentation
takayuki5168
approved these changes
Jun 7, 2024
zulfaqar-azmi-t4
force-pushed
the
RT1-6683-autoware-prefix-for-pure-pursuit
branch
from
d69a95f
to
e9b8e02
Compare
takayuki5168
added
the
tag:run-build-and-test-differential
zulfaqar-azmi-t4
force-pushed
the
RT1-6683-autoware-prefix-for-pure-pursuit
branch
3 times, most recently
from
ef527dd
to
92d1125
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
force-pushed
the
RT1-6683-autoware-prefix-for-pure-pursuit
branch
from
637f54e
to
90543ca
Compare
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…7301) * RT1-6683 add autoware prefix to package and namepace Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix precommit Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.
Part of:
Tests performed
Change lateral controller method so that pure pursuit is used.
run psim and ensure that the vehicle can be engaged.
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.