Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autonomous_emergency_braking): prefix package and namespace with autoware_ #7294

Merged

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented Jun 6, 2024

Description

As part of the push to add the autoware prefix.
Note: requires launch changes autowarefoundation/autoware_launch#1019

Part of:

Related links

Tests performed

PSim

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jun 6, 2024
@danielsanchezaran danielsanchezaran changed the title feat(autonomous_emergency_braking): Add autoware prefix to AEB feat(autonomous_emergency_braking): add autoware prefix to aeb Jun 6, 2024
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@github-actions github-actions bot removed the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Jun 6, 2024
@danielsanchezaran danielsanchezaran changed the title feat(autonomous_emergency_braking): add autoware prefix to aeb feat(autonomous_emergency_braking): prefix package and namespace with autoware_ Jun 6, 2024
@takayuki5168 takayuki5168 merged commit b1749af into autowarefoundation:main Jun 7, 2024
27 of 29 checks passed
@takayuki5168 takayuki5168 deleted the add-autoware-prefix-to-aeb branch June 7, 2024 13:18
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
… autoware_ (#7294)

* change package name

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add the prefix

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* change option

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* change back node name

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* eliminate some prefixes that are not required

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix node name

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants