refactor(operation_mode_transition_manager): prefix package and namespace with autoware_ #7291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulfaqar-azmi-t4
requested review from
TakaHoribe,
takayuki5168 and
tkimura4
as code owners
github-actions
bot
added
type:documentation
zulfaqar-azmi-t4
added
the
tag:deploy-docs
zulfaqar-azmi-t4
force-pushed
the
RT1-6682-autoware-prefix-for-operation-mode-transition-manager
branch
from
6e51340
to
dc97a21
Compare
go-sakayori
reviewed
Jun 6, 2024
| @@ -1,5 +1,5 @@ | |||
| <package format="3"> | |||
| <name>operation_mode_transition_manager</name> | |||
| <name>autoware_operation_mode_transition_manager</name> | |||
| <version>0.1.0</version> | |||
| <description>The vehicle_cmd_gate package</description> | |||
There was a problem hiding this comment.
Not really related to this PR, but think the description is wrong.
Just to let you know. (I realized since I was modifying the vehicle_cmd_gate)
There was a problem hiding this comment.
I didn't notice it!
Thank you Sakayori-san. I'll just change them in this PR.
zulfaqar-azmi-t4
force-pushed
the
RT1-6682-autoware-prefix-for-operation-mode-transition-manager
branch
from
dc97a21
to
51f5be4
Compare
takayuki5168
approved these changes
Jun 7, 2024
zulfaqar-azmi-t4
force-pushed
the
RT1-6682-autoware-prefix-for-operation-mode-transition-manager
branch
from
3b68025
to
31b0c14
Compare
zulfaqar-azmi-t4
force-pushed
the
RT1-6682-autoware-prefix-for-operation-mode-transition-manager
branch
from
31b0c14
to
513c339
Compare
zulfaqar-azmi-t4
added
the
tag:run-build-and-test-differential
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
force-pushed
the
RT1-6682-autoware-prefix-for-operation-mode-transition-manager
branch
from
513c339
to
b8a2bdc
Compare
zulfaqar-azmi-t4
merged commit dcf6b81
into
autowarefoundation:main
23 of 24 checks passed
zulfaqar-azmi-t4
deleted the
RT1-6682-autoware-prefix-for-operation-mode-transition-manager
branch
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…pace with autoware_ (#7291) * RT1-6682 add prefix package and namespace with autoware_ Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * RT1-6682 fix package's description Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
autoware_prefix to the package and puts headers in the autoware namespace.Part of:
Tests performed
Build success and autoware is running.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.