Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_velocity_smoother, autoware_path_optimizer): rename packages #7202

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 31, 2024

Description

Rename following packages:

  • motion_velocity_smoother -> autoware_velocity_smoother
  • obstacle_avoidance_planner -> autoware_path_optimizer

Related links

Tests performed

  • PASS TIER IV INTERERNAL SCENARIOS

Notes for reviewers

Interface changes

ROS Topic Changes

Before

Topic Name Type Direction
/planning/scenario_planning/motion_velocity_smoother/trajectory autoware_auto_trajectory_msgs/Trajectory Pub/Sub
/planning/scenario_planning/lane_driving/motion_planning/obstacle_avoidance_planner/trajectory autoware_auto_trajectory_msgs/Trajectory Pub/Sub

After

Topic Name Type Direction
/planning/scenario_planning/velocity_smoother/trajectory autoware_auto_trajectory_msgs/Trajectory Pub/Sub
/planning/scenario_planning/lane_driving/motion_planning/path_optimizer/trajectory autoware_auto_trajectory_msgs/Trajectory Pub/Sub

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels May 31, 2024
@satoshi-ota satoshi-ota marked this pull request as ready for review June 3, 2024 00:08
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 3, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) June 3, 2024 02:40
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your works

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…pace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@mitsudome-r mitsudome-r disabled auto-merge June 3, 2024 07:00
@mitsudome-r mitsudome-r enabled auto-merge (squash) June 3, 2024 07:02
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@mitsudome-r mitsudome-r disabled auto-merge June 3, 2024 12:15
@mitsudome-r mitsudome-r merged commit d2f41bc into autowarefoundation:main Jun 3, 2024
20 of 22 checks passed
@mitsudome-r mitsudome-r deleted the chore/rename-motion-package branch June 3, 2024 12:15
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…ckages (autowarefoundation#7202)

* chore(autoware_path_optimizer): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(autoware_static_centerline_generator): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore: update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(autoware_velocity_smoother): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(tier4_planning_launch): update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore: update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix: test

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix: test

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix: test

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ckages (#7202)

* chore(autoware_path_optimizer): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(autoware_static_centerline_generator): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore: update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(autoware_velocity_smoother): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(tier4_planning_launch): update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore: update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix: test

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix: test

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix: test

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.