refactor(autoware_velocity_walkway_module): prefix package with autoware_ and move code to the autoware namespace #7153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
added
the
tag:run-build-and-test-differential
github-actions
bot
added
type:documentation
esteve
force-pushed
the
prefix-behavior_velocity_walkway_module
branch
from
c19d864
to
7d7dcdf
Compare
github-actions
bot
added
the
component:launch
esteve
force-pushed
the
prefix-behavior_velocity_walkway_module
branch
from
a9b6f91
to
818b9f4
Compare
esteve
requested review from
satoshi-ota,
shmpwk,
takayuki5168,
tkimura4,
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
maxime-clem,
taikitanaka3,
TomohitoAndo,
rej55,
TakaHoribe and
zulfaqar-azmi-t4
as code owners
soblin
approved these changes
Jun 4, 2024
esteve
force-pushed
the
prefix-behavior_velocity_walkway_module
branch
from
7fb75ee
to
1cf2230
Compare
kosuke55
approved these changes
Jun 5, 2024
satoshi-ota
approved these changes
Jun 5, 2024
esteve
force-pushed
the
prefix-behavior_velocity_walkway_module
branch
2 times, most recently
from
88c0a03
to
b570ca6
Compare
|
@esteve |
|
@yuki-takagi-66 thanks, but I'm already working on it |
…are_ and move code to the autoware namespace Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
esteve
force-pushed
the
prefix-behavior_velocity_walkway_module
branch
from
b570ca6
to
b034ec5
Compare
|
@yuki-takagi-66 all conflicts are resolved now |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jun 6, 2024
…are_ and move code to the autoware namespace (autowarefoundation#7153) * refactor(autoware_velocity_walkway_module): prefix package with autoware_ and move code to the autoware namespace Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * fix: fix issue loading packages that have been prefixed Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> --------- Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…are_ and move code to the autoware namespace (#7153) * refactor(autoware_velocity_walkway_module): prefix package with autoware_ and move code to the autoware namespace Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * fix: fix issue loading packages that have been prefixed Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> --------- Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
autoware_ prefixto the package and puts headers in theautowarenamespace.Part of:
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.