Fix #139 strictSsl: false option being ignored

src/wrappers/request.js

@@ -21,9 +21,9 @@ export default function(options, cb) {
     };
   } 
 
-  if (options.agentOptions || options.strictSSL) {
+  if (options.agentOptions || options.strictSSL != undefined) {
     const agentOptions = {
-      ...(options.strictSSL) && { rejectUnauthorized: options.strictSSL },
+      ...(options.strictSSL != undefined) && { rejectUnauthorized: options.strictSSL },
       ...options.agentOptions
     };
     requestOptions.httpAgent = new http.Agent(agentOptions);

tests/request.tests.js

@@ -0,0 +1,47 @@
+import axios from 'axios';
+import { expect } from 'chai';
+
+import request from '../src/wrappers/request';
+
+describe('Request wrapper tests', () => {
+
+  const uri = 'https://foo/bar';
+  const originalAxiosRequest = axios.request;
+  const mockedAxiosRequest = (options) => {
+    return Promise.resolve(options);
+  };
+  before(() => {
+    axios.request = mockedAxiosRequest;
+  });
+
+  after(() => {
+    axios.request = originalAxiosRequest;
+  });
+
+  describe('default export', () => {
+    describe('should pass through strictSSL option properly', () => {
+      it('should create agentOptions if strictSSL === true', (done) => {
+        request({ uri, strictSSL: true }, (err, options) => {
+          expect(options.httpsAgent).to.be.defined;
+          expect(options.httpsAgent.options.rejectUnauthorized).to.be.true;
+          done(err);
+        });
+      });
+
+      it('should create agentOptions if strictSSL === false', (done) => {
+        request({ uri, strictSSL: false }, (err, options) => {
+          expect(options.httpsAgent).to.be.defined;
+          expect(options.httpsAgent.options.rejectUnauthorized).to.be.false;
+          done(err);
+        });
+      });
+
+      it('should not create agentOptions if strictSSL === undefined', (done) => {
+        request({ uri }, (err, options) => {
+          expect(options.httpsAgent).to.be.undefined;
+          done(err);
+        });
+      });
+    });
+  });
+});