Fix #139 strictSsl: false option being ignored

[kopancek]

Description

Fixed a bug, when passing in strictSsl: false option, it was ignored because of bad boolean logic handling in the request wrapper.

References

fixes #139

Testing

Unit tested locally.

• This change adds test coverage for new/changed/fixed functionality

Checklist

• I have added documentation for new/changed functionality in this PR or in auth0.com/docs
• All active GitHub checks for tests, formatting, and security are passing
• The correct base branch is being used, if not master

[kopancek]

As far as I have seen, the tests were already failing on master locally without my changes. Not sure why.

[lbalmaceda]

LGTM.
The tests on master seem to have passed correctly for the last time 2 months ago, according to this https://circleci.com/gh/auth0/node-jwks-rsa/45. I imagine it could be related to the node engine version, or maybe invalid packages being installed. Let me know if you need help to figure that out and I'll reach out to my team.

[lbalmaceda]

I just cloned the repo locally and ran the tests on master. Everything looking good here @kopancek

My node version is 12.9.1 (~LTS)

[adamjmcgrath]

Hi @kopancek

Can you move your axios stub into a before. If you stub axios at import time it will leak into tests that run before the request.test.js file is executed. (you can do this in jest, but not mocha)

Changing requests.test.js to:

describe('Request wrapper tests', () => {

  const uri = 'https://foo/bar';
  let originalAxiosRequest;

  before(() => {
    originalAxiosRequest = axios.request;
    const mockedAxiosRequest = (options) => {
      return Promise.resolve(options);
    };
    axios.request = mockedAxiosRequest;
  });

  after(() => {
    axios.request = originalAxiosRequest;
  });

Should fix the build

[kopancek]

Hi @kopancek

Can you move your axios stub into a before. If you stub axios at import time it will leak into tests that run before the request.test.js file is executed. (you can do this in jest, but not mocha)

Changing requests.test.js to:

describe('Request wrapper tests', () => {

  const uri = 'https://foo/bar';
  let originalAxiosRequest;

  before(() => {
    originalAxiosRequest = axios.request;
    const mockedAxiosRequest = (options) => {
      return Promise.resolve(options);
    };
    axios.request = mockedAxiosRequest;
  });

  after(() => {
    axios.request = originalAxiosRequest;
  });

Should fix the build

I just noticed the same, the CI should now pass.