-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid expanding single-element tuple patterns #7683
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
use ruff_formatter::{Format, FormatResult}; | ||
use ruff_formatter::{format_args, Format, FormatResult}; | ||
use ruff_python_ast::node::AnyNodeRef; | ||
use ruff_python_ast::PatternMatchSequence; | ||
use ruff_python_trivia::{SimpleTokenKind, SimpleTokenizer}; | ||
|
@@ -20,14 +20,25 @@ impl FormatNodeRule<PatternMatchSequence> for FormatPatternMatchSequence { | |
let dangling = comments.dangling(item); | ||
|
||
let sequence_type = SequenceType::from_pattern(item, f.context().source()); | ||
if patterns.is_empty() { | ||
return match sequence_type { | ||
SequenceType::List => empty_parenthesized("[", dangling, "]").fmt(f), | ||
SequenceType::Tuple | SequenceType::TupleNoParens => { | ||
empty_parenthesized("(", dangling, ")").fmt(f) | ||
} | ||
}; | ||
|
||
match (patterns.as_slice(), sequence_type) { | ||
// If the sequence is empty, the parentheses with any dangling comments. | ||
([], SequenceType::Tuple | SequenceType::TupleNoParens) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This comment seems to miss at least a verb. |
||
return empty_parenthesized("(", dangling, ")").fmt(f) | ||
} | ||
([], SequenceType::List) => return empty_parenthesized("[", dangling, "]").fmt(f), | ||
|
||
// A single-element tuple should always be parenthesized, and the trailing comma | ||
// should never cause it to expand. | ||
([elt], SequenceType::Tuple | SequenceType::TupleNoParens) => { | ||
return parenthesized("(", &format_args![elt.format(), token(",")], ")") | ||
.with_dangling_comments(dangling) | ||
.fmt(f) | ||
} | ||
|
||
_ => {} | ||
} | ||
|
||
let items = format_with(|f| { | ||
f.join_comma_separated(range.end()) | ||
.nodes(patterns.iter()) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some more tests with comments?