Avoid expanding single-element tuple patterns #7683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/pat
branch
2 times, most recently
from
eb2ef9d
to
d54079d
Compare
MichaReiser
reviewed
Sep 28, 2023
|
|
||
|
|
||
| # Single-element tuples. | ||
| match pattern: |
There was a problem hiding this comment.
Can we add some more tests with comments?
| }; | ||
|
|
||
| match (patterns.as_slice(), sequence_type) { | ||
| // If the sequence is empty, the parentheses with any dangling comments. |
There was a problem hiding this comment.
This comment seems to miss at least a verb.
charliermarsh
added a commit
that referenced
this pull request
Sep 28, 2023
Just changes to internal comments and tests. See comments in #7683.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The formatting for tuple patterns is now intended to match that of
forloops:Closes #7681.
Test Plan
cargo test