-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some text are invisible (same as background color) #32
Comments
Hello, |
This is weird, it never happened on my vim... Have you tried with a clean gnome-terminal profile ? |
I can confirm that the colors are the same. I have seen this when running javascript tests, and I change to the light background when it is a problem. But I'm sure we can get into the same situation for a light background as well. I think this has to be changed where the colors are set, in dircolors. |
Well, BASE03 gets used both for the background and the 9th entry in the PALETTE.
For me it's btw "gray" (from Zsh's $fg array) which is also mapped to "black". @Anthony25 it's not about Vim here, but gnome-terminal. It's also a problem with Terminator [1], which has a built-in scheme "Solarized black" (when using the Solarized palette also). |
I can confirm this and I'm seeing it in the same use case (running unit tests). What'd you change the color to for the second screenshot? |
This seems we will have problems like this with coloured outputs using solarized. altercation/solarized#220 describes several tools outputting grey and giving problems like this. Solarized may need a fix that will be hard to implement because of the use grey background. In the mentioned issue, you can find links to a fork that may work for you. |
Was the intent to change the background color? My background is all washed out now. i.e. BASE01. |
I didn't see the difference that's why I pulled this commit because it seems to fix the invisible text without changing anything. If you prefered the old color, I revert the commit. |
The old color is the correct color. The invisible output is a bug between the other libs. (Solarized has too few colors for the other tools… or something like that) |
Okay I see, sorry about that. I'm reverting the commit. |
This reverts commit ff1e664. Not the correct color in fact
This is a pretty well known bug in the Solarized palette. I found a way to fix it but it breaks compatibility with any programs like vim that have a Solarized colorscheme. Here's my writeup on the fix. Sorry for the shameless self-plug, but as far as I can tell nobody has come up with another solution yet. |
FWIW, here is a simple script to output a table of all colors, which might help to address this issue: https://github.com/blueyed/dotfiles/blob/master/usr/bin/colors-table |
gnome-terminal allows setting a different text and background color (which must not be in the palette). Can't this be used? The palette would stay the same (and no changes to the Vim (and other apps') colorscheme would be needed), but gnome-terminal would use a slightly different background color. Also, please re-open this issue. |
Well, this script respects the solarized colorsheme, and I have exactly the same problem with urxvt (that I have solved in installing the solarized theme for vim). The question is : do you prefer having a terminal with the solarized colors and a vim which needs the solarized theme, or a terminal with a different background than the solarized one, with a vim less broken (but still uglier than with the solarized vim theme) ? |
I am using the solarized theme for Vim (cherry-picked fixes from other forks; https://github.com/blueyed/vim-colors-solarized), and it appears to work fine with gnome-terminal-colors-solarized. |
Which color do you suggest for the background ? |
I have both the vim solarized theme and the gnome-terminal solarized theme. There are no adverse affects to using this combination that I see with the changes I made in ff1e664. @armyofzin @sigurdga, what combination of themes/configurations causes issues for you? |
Hi, I got a similar problem. I installed this theme yesterday. I am using dark theme with dircolors.ansi-dark. In htop program, the percentage numbers are invisible when this theme profile is selected in gnome-terminal. When I change the profile to the default one, they become visible again. |
Hello @sgon00, |
Hello @Anthony25, thanks a lot for the suggestion. I never know I can change htop color theme before. Just found out in F2 setup menu of htop. The background color is cool to me. I am using solarized theme everywhere. Thanks. |
I like it too, the problem is that 2 colors are identical, and some soft like htop or vim are using these 2 colors to contrast. It's an upstream bug, directly linked with the official solarized color-scheme... |
This reverts commit ff1e664. Not the correct color in fact
* usr/share/gnome-terminal-colors-solarized d9fcb57...84d885c (17): > Adapt the README to the last commits > Fix bug with gconf > Project more modular > set_dark and set_light apply theme for default theme > Complete the README > Remove unnecessary files > Adapt help to the new colors modifications > Profiles standardisation > New color palettes to fix colors in gnome terminal. Madea backup of old palettes in the colors/.palette*_backup files > Remove the 80 chars/l splitting > Fix typo in README > Revert "Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32" > Merge https://github.com/sveiss/gnome-terminal-colors-solarized > Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32 > Invite anybody to make a fork for Mate > Move the python script in a branch > Merge pull request #41 from sveiss/fix-quoting
@jmatth your fix worked for me so far. Thanks a lot! |
The text will be visible if you set iterm2's contrast a little bit higher. Go to Preferences > Profiles > Colors > Minimum contrast and set the slider a little bit to the right and you will see the invisible text. (Also see https://www.iterm2.com/documentation-one-page.html, search for "contrast".) Even tho not a solution to the actual problem this might help most people who run into the same problem. ;) |
JFI: while I am not using gnome-terminal for a while already, I've switched to using base16 recently, and it has profiles for gnome-terminal, too: https://github.com/chriskempson/base16-gnome-terminal Together with https://github.com/chriskempson/base16-shell (and a modified colorscheme for Vim (https://github.com/blueyed/vim-colors-solarized) this seems to be a good fix for me. |
* usr/share/gnome-terminal-colors-solarized d9fcb57...84d885c (17): > Adapt the README to the last commits > Fix bug with gconf > Project more modular > set_dark and set_light apply theme for default theme > Complete the README > Remove unnecessary files > Adapt help to the new colors modifications > Profiles standardisation > New color palettes to fix colors in gnome terminal. Madea backup of old palettes in the colors/.palette*_backup files > Remove the 80 chars/l splitting > Fix typo in README > Revert "Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32" > Merge https://github.com/sveiss/gnome-terminal-colors-solarized > Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32 > Invite anybody to make a fork for Mate > Move the python script in a branch > Merge pull request #41 from sveiss/fix-quoting
* usr/share/gnome-terminal-colors-solarized d9fcb57...84d885c (17): > Adapt the README to the last commits > Fix bug with gconf > Project more modular > set_dark and set_light apply theme for default theme > Complete the README > Remove unnecessary files > Adapt help to the new colors modifications > Profiles standardisation > New color palettes to fix colors in gnome terminal. Madea backup of old palettes in the colors/.palette*_backup files > Remove the 80 chars/l splitting > Fix typo in README > Revert "Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32" > Merge https://github.com/sveiss/gnome-terminal-colors-solarized > Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32 > Invite anybody to make a fork for Mate > Move the python script in a branch > Merge pull request #41 from sveiss/fix-quoting
* usr/share/gnome-terminal-colors-solarized d9fcb57...84d885c (17): > Adapt the README to the last commits > Fix bug with gconf > Project more modular > set_dark and set_light apply theme for default theme > Complete the README > Remove unnecessary files > Adapt help to the new colors modifications > Profiles standardisation > New color palettes to fix colors in gnome terminal. Madea backup of old palettes in the colors/.palette*_backup files > Remove the 80 chars/l splitting > Fix typo in README > Revert "Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32" > Merge https://github.com/sveiss/gnome-terminal-colors-solarized > Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32 > Invite anybody to make a fork for Mate > Move the python script in a branch > Merge pull request #41 from sveiss/fix-quoting
* usr/share/gnome-terminal-colors-solarized d9fcb57...84d885c (17): > Adapt the README to the last commits > Fix bug with gconf > Project more modular > set_dark and set_light apply theme for default theme > Complete the README > Remove unnecessary files > Adapt help to the new colors modifications > Profiles standardisation > New color palettes to fix colors in gnome terminal. Madea backup of old palettes in the colors/.palette*_backup files > Remove the 80 chars/l splitting > Fix typo in README > Revert "Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32" > Merge https://github.com/sveiss/gnome-terminal-colors-solarized > Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32 > Invite anybody to make a fork for Mate > Move the python script in a branch > Merge pull request #41 from sveiss/fix-quoting
So because the 9th color in the palette is Base03 which is the same as the background, so now in a lot of my log outputs or test results and so on, that color is used..
The issue is that I can change that color in the palette but then my vim background color is that same color because of the fact that when you do background=dark in VIM, it seems to use that 9th color in the palette..
Any ideas on how I can handle both cases?
The text was updated successfully, but these errors were encountered: