Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renders invisible colours when using dark theme #930

Closed
lonix1 opened this issue Aug 27, 2022 · 4 comments
Closed

Renders invisible colours when using dark theme #930

lonix1 opened this issue Aug 27, 2022 · 4 comments
Labels
bug Something isn't working needs triage

Comments

@lonix1
Copy link
Contributor

lonix1 commented Aug 27, 2022

Information

  • OS: linux
  • Version: ubuntu 20
  • Terminal: gnome terminal
  • zsh 5.8
  • dotnet 6.0.400 with agnoster theme
  • Spectre.Console 0.44.0

Describe the bug
Some items are rendered in colours which cannot be seen in the terminal.

To Reproduce

  • create project
    dotnet new console -o Demo
    cd Demo
    dotnet add package Spectre.Console
  • Add code from the getting started page
  • $ dotnet run -- --help

Expected behavior
To be rendered so that I can see everything

Screenshots
spectre

Additional context
I thought it could be zsh, or zsh's "agnoster" theme. So I ran it in dash without any theming:

sh
dotnet run -- --help

That produced the same output as above, so it's not the shell.

@lonix1 lonix1 added the bug Something isn't working label Aug 27, 2022
@lonix1
Copy link
Contributor Author

lonix1 commented Aug 27, 2022

I had an idea that maybe it's the terminal's theme. My gnome-terminal uses the extremely popular "Solarized Dark" theme. When I changed it to a light theme, I could see that text. So the conflict is definitely the terminal theme.

However, when I chose any other dark theme, I got the same problem - so the problem is dark themes in general.

Do the colours rendered by Spectre work nicely with dark themes?

@lonix1 lonix1 changed the title Renders some colours as invisible Renders invisible colours when using dark theme Aug 27, 2022
@lonix1
Copy link
Contributor Author

lonix1 commented Aug 27, 2022

Another example, using the code from the commands page:

spectre2

@lonix1
Copy link
Contributor Author

lonix1 commented Sep 3, 2022

Obviously it's just me.

If anyone else has this issue let me know maybe we can compare notes to repro the problem.

@lonix1 lonix1 closed this as completed Sep 3, 2022
@lonix1
Copy link
Contributor Author

lonix1 commented Sep 5, 2022

Solarized Dark theme was the problem, known issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

2 participants