Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't rebuild ui/dist/app/index.html in argocli-build stage #13023

Merged
merged 3 commits into from
May 8, 2024
Merged

fix: don't rebuild ui/dist/app/index.html in argocli-build stage #13023

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9822dbd
fix: don't rebuild ui/dist/app/index.html
Joibel May 8, 2024
cd5b8b2
Update Dockerfile
Joibel May 8, 2024
d642063
Merge branch 'main' into fix-argocli-build
agilgur5 May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ ARG GIT_TREE_STATE

RUN mkdir -p ui/dist
COPY --from=argo-ui ui/dist/app ui/dist/app
# update timestamp so that `make` doesn't try to rebuild this -- it was already built in the previous stage
RUN touch ui/dist/app/index.html

RUN --mount=type=cache,target=/go/pkg/mod --mount=type=cache,target=/root/.cache/go-build STATIC_FILES=true make dist/argo GIT_COMMIT=${GIT_COMMIT} GIT_TAG=${GIT_TAG} GIT_TREE_STATE=${GIT_TREE_STATE}

Expand Down
Loading