fix: don't rebuild ui/dist/app/index.html in argocli-build stage
#13023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timestamps in CI are incorrect, and may result in an attempt to rebuild this file when we don't have yarn installed. So don't. Signed-off-by: Alan Clucas <alan@clucas.org>
|
This should have run e2e tests really, but it didn't. |
agilgur5
reviewed
May 8, 2024
We may want to add |
See also Slack thread for some debugging details on this |
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Alan Clucas <alan@clucas.org>
|
Would like to rebase this on top of #13024 to make sure E2Es run and pass here, otherwise LGTM |
agilgur5
changed the title
ui/dist/app/index.html
agilgur5
changed the title
ui/dist/app/index.htmlui/dist/app/index.html in argo-cli stage
agilgur5
changed the title
ui/dist/app/index.html in argo-cli stageui/dist/app/index.html in argocli-build stage
agilgur5
approved these changes
May 8, 2024
|
Thank you for testing and getting them through Anton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timestamps in CI are incorrect, and may result in an attempt to rebuild this file when we don't have yarn installed. So don't.
This is a problem introduced in #13018. edit by agilgur5: See also Slack thread for some debugging details on this
The timestamps don't always line up like expected when we come to check if we need to rebuild ui/dist/app/index.heml in the argocli-build step so force them fixed.