Argument order #444
Merged
Argument order #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlnilsson
force-pushed
the
argument-order
branch
from
deab695
to
96565db
Compare
in cases where all credentials are resolved without config file (environment variables) we need to run these functions in the right order, first resolve the root.PersistentPreRunE (to resolve the bearer token etcetra) after we have resolved those values, we can continue with the sub-command and correctly assert opts.Appliance() without having to worry about empty Authorization header value, which is the current case in the main branch. This PR fixes cases where we have disabled keyring and do not persist the bearer token value, as example: ```bash SDPCTL_URL=https://controller.appgate.devops:8443/ SDPCTL_API_VERSION=19 SDPCTL_NO_KEYRING=true SDPCTL_USERNAME=usernmaeSDPCTL_PASSWORD=the_password sdpctl appliance export-seed ```
dlnilsson
force-pushed
the
argument-order
branch
from
96565db
to
0667cf3
Compare
|
Tests fails because of #442 |
kajes
approved these changes
Aug 15, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in cases where all credentials are resolved without config file (environment variables)
we need to run these functions in the right order, first resolve the root.PersistentPreRunE (to resolve the bearer token etcetra)
after we have resolved those values, we can continue with the sub-command and correctly assert opts.Appliance() without having to worry about empty Authorization header value, which is the current case in the main branch.
This PR fixes cases where we have disabled keyring and do not persist the bearer token value, as example: