-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use PreRunE instead of Args for functions utilizing config values
in cases where all credentials are resolved without config file (environment variables) we need to run these functions in the right order, first resolve the root.PersistentPreRunE (to resolve the bearer token etcetra) after we have resolved those values, we can continue with the sub-command and correctly assert opts.Appliance() without having to worry about empty Authorization header value, which is the current case in the main branch. This PR fixes cases where we have disabled keyring and do not persist the bearer token value, as example: ```bash SDPCTL_URL=https://controller.appgate.devops:8443/ SDPCTL_API_VERSION=19 SDPCTL_NO_KEYRING=true SDPCTL_USERNAME=usernmaeSDPCTL_PASSWORD=the_password sdpctl appliance export-seed ```
- Loading branch information
Showing
7 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters