Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callback queue for Websocket #1507

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Fix callback queue for Websocket #1507

merged 1 commit into from
Nov 10, 2020

Conversation

designatednerd
Copy link
Contributor

This addresses #1504 and #1505, which correctly noted that a new callback queue parameter was added to send and then not used by the WebSocketTransport. Whoops! 🤦‍♀️

@designatednerd designatednerd added this to the Next Release milestone Nov 10, 2020
@designatednerd designatednerd mentioned this pull request Nov 10, 2020
Closed
@designatednerd designatednerd merged commit 85caac5 into main Nov 10, 2020
@RolandasRazma RolandasRazma mentioned this pull request Nov 11, 2020
Closed
@designatednerd designatednerd deleted the fix/websocket-callback-queue branch November 11, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnwalraven martijnwalraven martijnwalraven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.37.0
Development

Successfully merging this pull request may close these issues.
2 participants
@designatednerd @martijnwalraven