Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callbackQueue is not used in WebSocketTransport #1504

Closed
RolandasRazma opened this issue Nov 10, 2020 · 3 comments
Closed

callbackQueue is not used in WebSocketTransport #1504

RolandasRazma opened this issue Nov 10, 2020 · 3 comments
Labels
apollo-websockets bug Generally incorrect behavior
Milestone
0.37.0

Comments

@RolandasRazma
Copy link
Contributor

Bug report

apollo-ios/Sources/ApolloWebSocket/WebSocketTransport.swift

Line 361 in 185d6b7

callbackQueue: DispatchQueue = .main,
callbackQueue is unused

Versions

Please fill in the versions you're currently using:

  • apollo-ios SDK version: 0.36.0

Steps to reproduce

subscribe using any callbackQueue, callback is done on some internal one
@designatednerd designatednerd added apollo-websockets bug Generally incorrect behavior labels Nov 10, 2020
@designatednerd designatednerd mentioned this issue Nov 10, 2020
Merged
@designatednerd designatednerd added this to the Next Release milestone Nov 10, 2020
@designatednerd
Copy link
Contributor

Welp, that's embarrassing. Fix is up in #1507.

@RolandasRazma
Copy link
Contributor Author

thanks

@designatednerd
Copy link
Contributor

Thank YOU for catching it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apollo-websockets bug Generally incorrect behavior
Projects
None yet
Milestone
0.37.0
Development

No branches or pull requests
2 participants
@RolandasRazma @designatednerd