fix: Don't setState on unmounted ad (#5)

Don't set state on an unmounted ad. Cribbed from axioscode@9425436.
apartmenttherapy · Jan 17, 2019 · d7d6173 · d7d6173
1 parent 9f0fc73
commit d7d6173
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/Bling.js b/src/Bling.js
@@ -477,13 +477,20 @@ class Bling extends Component {
         }
     }
 
+    isAdMounted() {
+        return Bling._adManager.getMountedInstances().indexOf(this) !== -1;
+    }
+
     onScriptLoaded() {
         const {onScriptLoaded} = this.props;
 
         if (this.getRenderWhenViewable()) {
             this.foldCheck();
         }
-        this.setState({scriptLoaded: true}, onScriptLoaded); // eslint-disable-line react/no-did-mount-set-state
+
+        if (this.isAdMounted()) {
+            this.setState({scriptLoaded: true}, onScriptLoaded); // eslint-disable-line react/no-did-mount-set-state
+        }
     }
 
     onScriptError(err) {

diff --git a/test/Bling.spec.js b/test/Bling.spec.js
@@ -749,4 +749,19 @@ describe("Bling", () => {
         instance.componentWillUnmount();
         expect(Bling._adManager.getMountedInstances()).to.have.length(0);
     });
+
+    it("does not call props.onSlotLoaded if it has been unmounted", () => {
+        const onScriptLoaded = sinon.stub();
+        const instance = ReactTestUtils.renderIntoDocument(
+            <Bling
+                adUnitPath="/4595/nfl.test.open"
+                slotSize={[300, 250]}
+                onScriptLoaded={onScriptLoaded}
+            />
+        );
+        onScriptLoaded.reset();
+        instance.componentWillUnmount();
+        instance.onScriptLoaded();
+        expect(onScriptLoaded.called).to.be.false;
+    });
 });