Don't setState on an unmounted ad.

axioscode · Jul 31, 2018 · 9425436 · 9425436
1 parent 60f6ce0
commit 9425436
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/Bling.js b/src/Bling.js
@@ -477,13 +477,20 @@ class Bling extends Component {
         }
     }
 
+    isAdMounted() {
+        return Bling._adManager.getMountedInstances().indexOf(this) !== -1;
+    }
+
     onScriptLoaded() {
         const { onScriptLoaded } = this.props;
 
         if (this.getRenderWhenViewable()) {
             this.foldCheck();
         }
-        this.setState({ scriptLoaded: true }, onScriptLoaded); // eslint-disable-line react/no-did-mount-set-state
+
+        if (this.isAdMounted()) {
+            this.setState({ scriptLoaded: true }, onScriptLoaded); // eslint-disable-line react/no-did-mount-set-state
+        }
     }
 
     onScriptError(err) {

diff --git a/test/Bling.spec.js b/test/Bling.spec.js
@@ -742,6 +742,21 @@ describe("Bling", () => {
         ReactTestUtils.renderIntoDocument(<Wrapper />);
     });
 
+    it("does not call props.onSlotLoaded if it has been unmounted", () => {
+        const onScriptLoaded = sinon.stub();
+        const instance = ReactTestUtils.renderIntoDocument(
+            <Bling
+                adUnitPath="/4595/nfl.test.open"
+                slotSize={[300, 250]}
+                onScriptLoaded={onScriptLoaded}
+            />
+        );
+        onScriptLoaded.reset();
+        instance.componentWillUnmount();
+        instance.onScriptLoaded();
+        expect(onScriptLoaded.called).to.be.false;
+    });
+
     it("removes itself from registry when unmounted", () => {
         const instance = ReactTestUtils.renderIntoDocument(
             <Bling adUnitPath="/4595/nfl.test.open" slotSize={[300, 250]} />