Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

During concurrent slice searches in IndexSearcher stop other tasks if one throws an Exception #12756

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

During concurrent slice searches in IndexSearcher stop other tasks if one throws an Exception #12756

wants to merge 2 commits into from

Commits on Nov 3, 2023

  1. During concurrent slice searches in IndexSearcher stop other tasks if… 

    … one throws an Exception.

Since TaskExecutor now waits for all concurrent tasks to finish, even if one throws an
Exception and when an exception is thrown, any remaining unscheduled tasks are cancelled,
the next step is to notify currently running tasks to exit early. This is done via a
a new QueryTimeout implementation, ExceptionBasedQueryTimeout, which holds a volatile
boolean of whether any other sibling task threw an exception. If the boolean is true,
then the shouldExit method returns true, so that the in progress task exits early.

Closes apache#12278
    @quux00
    quux00 committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c0e8969 View commit details
    Browse the repository at this point in the history

  2. Minor clean up of test code comments

    @quux00
    quux00 committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    314ecec View commit details
    Browse the repository at this point in the history