During concurrent slice searches in IndexSearcher stop other tasks if one throws an Exception #12756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quux00
force-pushed
the
concurrent-search/stop-all-on-exception
branch
from
dd0bb0a
to
78d2d5a
Compare
… one throws an Exception. Since TaskExecutor now waits for all concurrent tasks to finish, even if one throws an Exception and when an exception is thrown, any remaining unscheduled tasks are cancelled, the next step is to notify currently running tasks to exit early. This is done via a a new QueryTimeout implementation, ExceptionBasedQueryTimeout, which holds a volatile boolean of whether any other sibling task threw an exception. If the boolean is true, then the shouldExit method returns true, so that the in progress task exits early. Closes apache#12278
quux00
force-pushed
the
concurrent-search/stop-all-on-exception
branch
from
78d2d5a
to
c0e8969
Compare
stefanvodita
approved these changes
Nov 22, 2023
| public void testMultipleSegmentsWithExceptionCausesEarlyTerminationOfRunningTasks() { | ||
| // skip this test when only one leaf, since one leaf means one task | ||
| // and the TimeLimitingBulkScorer will NOT be added in IndexSearcher | ||
| if (reader.leaves().size() <= 1) { |
There was a problem hiding this comment.
There are other tests which create their own index. Is it worth doing that just to avoid this case? I'm not sure.
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since TaskExecutor now waits for all concurrent tasks to finish, even if one throws an Exception and when an exception is thrown, any remaining unscheduled tasks are cancelled, the next step is to notify currently running tasks to exit early. This is done via a a new QueryTimeout implementation, ExceptionBasedQueryTimeout, which holds a volatile boolean of whether any other sibling task threw an exception. If the boolean is true, then the shouldExit method returns true, so that the in progress task exits early.
Closes #12278