This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Lint in TravisCI and Update iOS TravisCI #2731
Add Lint in TravisCI and Update iOS TravisCI #2731
Changes from 83 commits
7e93ae3
034d38c
d6d127f
ed2e713
bbf9446
6cefc8d
175b747
2a2e998
1c99e59
5aa966d
da83adf
c2ff7d0
fce5c37
d226c55
70382ff
c19263c
45632bf
3825f00
798e867
cb0687b
345a85e
7804e01
629b759
0adc403
ca1573b
dc625cf
82c5bb6
eed9cc4
0cbc129
45dbeaf
dbcaa92
b6711dc
df518ad
d54f801
18a9573
d439e99
9907c91
d0407b9
a52a635
b189e3d
2d96450
b6cb33b
4b30d74
950a8cb
cedf4fb
69a406b
7b8def1
931cbc0
2aff44d
193124d
acc85c1
7cba71b
615f84d
bfc7a40
7a5f6b0
006c765
6dbff5c
310c32e
59ac991
8a36f04
160b8aa
e8321bc
c0e261f
78ffbd5
86de4c3
c678b2c
76f0e2f
d4d3efd
b7d474e
a4777c4
1467029
b58efdc
9bb8a10
266bcb6
ce77b0c
5b49f35
d943110
e199c3f
98f6545
97ae515
ce436aa
ddd48f7
efc4614
b66e8b8
d691708
3531b25
8ef0ecc
fef51dd
f79edc1
830bb6f
11dd0e5
bc05793
d25582d
1943636
e91e1e0
3083794
935cb49
daed95c
f3cf951
1d9d5a0
e563bbf
51a05c0
09bf60e
748fa44
65647dd
4c159fd
049f481
cba1a26
f07e90f
e3e9a0a
677c3fe
8dfff58
6e3b2e7
5d4c334
90c3a87
084777c
5a22656
392c836
1e5f1a6
efa2145
3e66136
2583824
d0b48c0
18bd209
b6aa447
cd13248
0400639
31004d0
241bb46
98dc055
7be8783
fb5fbb6
c535016
8ef6a10
fddd73a
2f2d3a7
6f62829
076be05
79494d2
9715008
b333353
e850657
4fbb51e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why adding this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because code format validator is based on danger plugin: code_style_validation
and this line in Dangerfile is to start format check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not that familiar with danger, please let me know when this
Dangerfile
will be executed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is the format code part in .travis I list above:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I am wrong.
It seems like you are using the ruby version of danger for
code_format
, and the ruby version danger will some useDangerfile
as its source.If this is the case, relying on
https://github.com/wrmswindmill/danger-code_style_validation.git
is not an option in my knowledge, as the source file could be changed in any minutes. At least, you should rely a publish version ofhttps://github.com/wrmswindmill/danger-code_style_validation.git
. I suggest you share your ideas in the mailing list.PS:
XCode
orAndroid Studio
) and format code with one click.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it rely on https://github.com/wrmswindmill/danger-code_style_validation.git, which I fork from https://github.com/flix-tech/danger-code_style_validation and I update some code for weex project. I will share this plugin in the mailing list as well as the static check in Travis CI.
here are some changes I make for danger-code_style_validation:
the below is my answer for your question: