-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add Lint in TravisCI and Update iOS TravisCI #2731
Conversation
…ssLoaderAdapter.java
…ssLoaderAdapter.java
…ssLoaderAdapter.java
|
|
|
Dangerfile
Outdated
@@ -0,0 +1 @@ | |||
code_style_validation.check file_extensions: ['.cc', '.cpp', '.m', 'mm', '.h', '.java'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I am wrong.
It seems like you are using the ruby version of danger for code_format
, and the ruby version danger will some use Dangerfile
as its source.
If this is the case, relying on https://github.com/wrmswindmill/danger-code_style_validation.git
is not an option in my knowledge, as the source file could be changed in any minutes. At least, you should rely a publish version of https://github.com/wrmswindmill/danger-code_style_validation.git
. I suggest you share your ideas in the mailing list.
PS:
- I don't see the output of the code format in danger.
- You should also provide a format script or file, within which developers could import the file into their IDE(
XCode
orAndroid Studio
) and format code with one click.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, there is a conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
I know debugging Travis-CI is a time-consuming and tedious task and I'm really appreciated your help in improving Weex CI
Brief Description of the PR
Add Static Check in Travis CI
Lint Tool Lists:
Check FileType
OCLint in .travis.yml
Android Lint in .travis.yml
Code Format
code format with danger-code_style_validation based on clang-format
clang-format support code format for program language like:java, c++, c, objective.
Update iOS
Todo
Links