-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix triple client stream executor #13178
Fix triple client stream executor #13178
Conversation
|
Codecov Report
@@ Coverage Diff @@
## 3.2 #13178 +/- ##
============================================
- Coverage 69.38% 69.36% -0.02%
Complexity 2 2
============================================
Files 1648 1648
Lines 68693 68694 +1
Branches 10014 10012 -2
============================================
- Hits 47661 47649 -12
- Misses 16438 16454 +16
+ Partials 4594 4591 -3 see 43 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add ping pong for tri protocol * add ping pong for tri protocol * add ping pong for tri protocol * add ping pong for tri protocol
This reverts commit 5a3be17.
…t-executor # Conflicts: # dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyConnectionClient.java
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
At present, executor of triple client uses wrong ThreadFactory and ThreadPool, default client thread pool is CachedThreadPool.
![image](https://private-user-images.githubusercontent.com/18413695/273852571-4f0d31c4-649a-48ce-843d-279664228b9c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyOTkwMzMsIm5iZiI6MTcyNDI5ODczMywicGF0aCI6Ii8xODQxMzY5NS8yNzM4NTI1NzEtNGYwZDMxYzQtNjQ5YS00OGNlLTg0M2QtMjc5NjY0MjI4YjljLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDAzNTIxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg2MGI3YzU0MjE5NDM5OWQ0M2Q2NDc0ZjRmZThiMzlkZWFmNzc3Nzg5Njk5NzdiYTgxOGI2YTllMDdmZWJjOWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.wXJ7HLLHi4VFTTfc-b2ZHIcD76e3oVLxKiqyXKgnQBs)
For example:
Brief changelog
Verifying this change
Checklist