-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ping pong for tri protocol #12955
Conversation
...dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleWritePingHandler.java
Outdated
Show resolved
Hide resolved
// int heartbeatInterval = UrlUtils.getHeartbeat(getUrl()); | ||
|
||
int idleTimeout = UrlUtils.getIdleTimeout(getUrl()); | ||
pipeline.addLast("client-idle-handler", new IdleStateHandler(idleTimeout, 0, 0, MILLISECONDS)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a idle handler and a close handler.
Codecov Report
@@ Coverage Diff @@
## 3.2 #12955 +/- ##
=============================================
+ Coverage 68.78% 69.41% +0.63%
+ Complexity 341 2 -339
=============================================
Files 3659 1651 -2008
Lines 171227 68542 -102685
Branches 28256 10001 -18255
=============================================
- Hits 117770 47581 -70189
+ Misses 43281 16370 -26911
+ Partials 10176 4591 -5585 see 2066 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
If we use port unification for both Dubbo and Triple protocol, will it work expectedly? |
Only Triple protocol will handle |
But Dubbo protocol alos use |
@guohao pPTAL |
Dubbo protocol's |
* add ping pong for tri protocol * add ping pong for tri protocol * add ping pong for tri protocol * add ping pong for tri protocol
This reverts commit 5a3be17.
* Fix error stream executor * add ping pong for tri protocol (#12955) * add ping pong for tri protocol * add ping pong for tri protocol * add ping pong for tri protocol * add ping pong for tri protocol * Revert "add ping pong for tri protocol (#12955)" This reverts commit 5a3be17. --------- Co-authored-by: Albumen Kevin <jhq0812@gmail.com> Co-authored-by: icodening <cleverbn96@gmail.com>
What is the purpose of the change
fix #12945
add ping pong for tri protocol
Brief changelog
add fixed delay write ping frame handler
Verifying this change
Checklist