Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ping pong for tri protocol #12955

Merged
merged 5 commits into from
Oct 11, 2023
Merged

add ping pong for tri protocol #12955

merged 5 commits into from
Oct 11, 2023

Conversation

icodening
Copy link
Contributor

@icodening icodening commented Aug 24, 2023

What is the purpose of the change

fix #12945
add ping pong for tri protocol

Brief changelog

add fixed delay write ping frame handler

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

// int heartbeatInterval = UrlUtils.getHeartbeat(getUrl());

int idleTimeout = UrlUtils.getIdleTimeout(getUrl());
pipeline.addLast("client-idle-handler", new IdleStateHandler(idleTimeout, 0, 0, MILLISECONDS));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a idle handler and a close handler.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2023

Codecov Report

Merging #12955 (28b1399) into 3.2 (c12a57e) will increase coverage by 0.63%.
Report is 5 commits behind head on 3.2.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                3.2   #12955       +/-   ##
=============================================
+ Coverage     68.78%   69.41%    +0.63%     
+ Complexity      341        2      -339     
=============================================
  Files          3659     1651     -2008     
  Lines        171227    68542   -102685     
  Branches      28256    10001    -18255     
=============================================
- Hits         117770    47581    -70189     
+ Misses        43281    16370    -26911     
+ Partials      10176     4591     -5585     

see 2066 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

51.5% 51.5% Coverage
0.0% 0.0% Duplication

@AlbumenJ
Copy link
Member

AlbumenJ commented Sep 5, 2023

If we use port unification for both Dubbo and Triple protocol, will it work expectedly?

@icodening
Copy link
Contributor Author

If we use port unification for both Dubbo and Triple protocol, will it work expectedly?

Only Triple protocol will handle IDLE state

@AlbumenJ
Copy link
Member

AlbumenJ commented Sep 7, 2023

If we use port unification for both Dubbo and Triple protocol, will it work expectedly?

Only Triple protocol will handle IDLE state

But Dubbo protocol alos use IDLE state too

@AlbumenJ
Copy link
Member

@guohao pPTAL

@guohao
Copy link
Contributor

guohao commented Oct 11, 2023

If we use port unification for both Dubbo and Triple protocol, will it work expectedly?

Only Triple protocol will handle IDLE state

Dubbo protocol's IDEL event can be supported in a seperated PR

@EarthChen EarthChen merged commit b84c138 into apache:3.2 Oct 11, 2023
14 checks passed
finefuture pushed a commit to finefuture/dubbo that referenced this pull request Oct 11, 2023
* add ping pong for tri protocol

* add ping pong for tri protocol

* add ping pong for tri protocol

* add ping pong for tri protocol
finefuture added a commit to finefuture/dubbo that referenced this pull request Oct 11, 2023
icodening added a commit that referenced this pull request Oct 11, 2023
* Fix error stream executor

* add ping pong for tri protocol (#12955)

* add ping pong for tri protocol

* add ping pong for tri protocol

* add ping pong for tri protocol

* add ping pong for tri protocol

* Revert "add ping pong for tri protocol (#12955)"

This reverts commit 5a3be17.

---------

Co-authored-by: Albumen Kevin <jhq0812@gmail.com>
Co-authored-by: icodening <cleverbn96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

服务端突然断网、断电,客户端无法进行故障转移
5 participants