Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics code opt: redundant, modifier, magic #11553

Merged
merged 6 commits into from
Feb 14, 2023
Merged

Metrics code opt: redundant, modifier, magic #11553

merged 6 commits into from
Feb 14, 2023

Conversation

mytang0
Copy link
Member

@mytang0 mytang0 commented Feb 13, 2023 •
edited
Loading

What is the purpose of the change

Issue #11554

  1. Remove redundant code
  2. Optimize modifier
  3. Optimize magic constant

Brief changelog

Verifying this change

Checklist

  • [yes] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

songxiaosheng
songxiaosheng approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlbumenJ
AlbumenJ approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mytang0
Merge branch '3.2' into code-opt
88b4b13 
* 3.2:
  Bump maven-assembly-plugin from 3.1.0 to 3.4.2 (apache#11547)
  Bump consul-api from 1.4.2 to 1.4.5 (apache#11545)
  Bump maven-core from 3.8.7 to 3.9.0 (apache#11546)
  Bump bytebuddy.version from 1.12.22 to 1.13.0 (apache#11548)
  Bump byte-buddy from 1.12.22 to 1.13.0 (apache#11550)
  Bump maven-plugin-api from 3.8.7 to 3.9.0 (apache#11551)
  Rename file cache to prevent being duplicated with CacheFilter (apache#11530)
  Fix hasPreparedInternalModule is always false. (apache#11535) (apache#11536)
  collect jacoco result (apache#11532)
  optimize MockDirInvocation setObjectAttachmentIfAbsent method code (apache#11527)
  Metrics Count Optimization (apache#11529)
  Tri grpc compatibility (apache#11544)
  Fix NPE when removing registry (apache#11514)

# Conflicts:
#	dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/DefaultMetricsCollector.java
#	dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/stat/MetricsStatComposite.java
@mytang0
Resolve conflicts
4458aed
@mytang0
Delete empty file
0321864
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit e1baaae into apache:3.2 Feb 14, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 15, 2023
@mytang0
Merge remote-tracking branch 'mytang0/3.2' into version
7ea65d4 
* mytang0/3.2:
  Enhance service discovery update interval (apache#11223)
  Metrics code opt: redundant, modifier, magic (apache#11553)
  Perfect some code (apache#11533)
  feat: dubbo provided by (apache#11390)
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 16, 2023
@mytang0
Merge remote-tracking branch 'mytang0/3.2' into service-payload
db21b8c 
* mytang0/3.2: (33 commits)
  Fix conflict
  Update codecov config (apache#11580)
  Set timeout value to string (apache#11565)
  Skip mapping retry if metadata config is invalid (apache#11323)
  Fix stackoverflow in SerializeSecurityConfigurator (apache#11561)
  Revert clear response operation of timeoutfilter (apache#11562)
  Fix hessian2 serializable check (apache#11573)
  feat: fix oom (apache#11571)
  Enhance service discovery update interval (apache#11223)
  Metrics code opt: redundant, modifier, magic (apache#11553)
  Perfect some code (apache#11533)
  feat: dubbo provided by (apache#11390)
  Enhance serializable check option (apache#11460)
  Fix config absent when refresh (apache#11505)
  Enhance json util check (apache#11501)
  Fix the bug in LFUCache#put() method (apache#11538)
  Bump maven-assembly-plugin from 3.1.0 to 3.4.2 (apache#11547)
  Bump consul-api from 1.4.2 to 1.4.5 (apache#11545)
  Bump maven-core from 3.8.7 to 3.9.0 (apache#11546)
  Bump bytebuddy.version from 1.12.22 to 1.13.0 (apache#11548)
  ...

# Conflicts:
#	dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java
@songxiaosheng songxiaosheng mentioned this pull request Feb 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

@songxiaosheng songxiaosheng songxiaosheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mytang0 @AlbumenJ @songxiaosheng