-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics code opt: redundant, modifier, magic #11553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songxiaosheng
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AlbumenJ
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 3.2: Bump maven-assembly-plugin from 3.1.0 to 3.4.2 (apache#11547) Bump consul-api from 1.4.2 to 1.4.5 (apache#11545) Bump maven-core from 3.8.7 to 3.9.0 (apache#11546) Bump bytebuddy.version from 1.12.22 to 1.13.0 (apache#11548) Bump byte-buddy from 1.12.22 to 1.13.0 (apache#11550) Bump maven-plugin-api from 3.8.7 to 3.9.0 (apache#11551) Rename file cache to prevent being duplicated with CacheFilter (apache#11530) Fix hasPreparedInternalModule is always false. (apache#11535) (apache#11536) collect jacoco result (apache#11532) optimize MockDirInvocation setObjectAttachmentIfAbsent method code (apache#11527) Metrics Count Optimization (apache#11529) Tri grpc compatibility (apache#11544) Fix NPE when removing registry (apache#11514) # Conflicts: # dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/DefaultMetricsCollector.java # dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/stat/MetricsStatComposite.java
Kudos, SonarCloud Quality Gate passed! |
mytang0
added a commit
to mytang0/dubbo
that referenced
this pull request
Feb 15, 2023
* mytang0/3.2: Enhance service discovery update interval (apache#11223) Metrics code opt: redundant, modifier, magic (apache#11553) Perfect some code (apache#11533) feat: dubbo provided by (apache#11390)
mytang0
added a commit
to mytang0/dubbo
that referenced
this pull request
Feb 16, 2023
* mytang0/3.2: (33 commits) Fix conflict Update codecov config (apache#11580) Set timeout value to string (apache#11565) Skip mapping retry if metadata config is invalid (apache#11323) Fix stackoverflow in SerializeSecurityConfigurator (apache#11561) Revert clear response operation of timeoutfilter (apache#11562) Fix hessian2 serializable check (apache#11573) feat: fix oom (apache#11571) Enhance service discovery update interval (apache#11223) Metrics code opt: redundant, modifier, magic (apache#11553) Perfect some code (apache#11533) feat: dubbo provided by (apache#11390) Enhance serializable check option (apache#11460) Fix config absent when refresh (apache#11505) Enhance json util check (apache#11501) Fix the bug in LFUCache#put() method (apache#11538) Bump maven-assembly-plugin from 3.1.0 to 3.4.2 (apache#11547) Bump consul-api from 1.4.2 to 1.4.5 (apache#11545) Bump maven-core from 3.8.7 to 3.9.0 (apache#11546) Bump bytebuddy.version from 1.12.22 to 1.13.0 (apache#11548) ... # Conflicts: # dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Issue #11554
Brief changelog
Verifying this change
Checklist