-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics Count Optimization #11529
Metrics Count Optimization #11529
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.2 #11529 +/- ##
============================================
- Coverage 69.67% 64.81% -4.86%
+ Complexity 119 14 -105
============================================
Files 1561 1514 -47
Lines 83705 62911 -20794
Branches 14924 9180 -5744
============================================
- Hits 58323 40778 -17545
+ Misses 20500 17898 -2602
+ Partials 4882 4235 -647
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@songxiaosheng PTAL |
# Conflicts: # dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/DefaultMetricsCollector.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
* 3.2: Bump maven-assembly-plugin from 3.1.0 to 3.4.2 (apache#11547) Bump consul-api from 1.4.2 to 1.4.5 (apache#11545) Bump maven-core from 3.8.7 to 3.9.0 (apache#11546) Bump bytebuddy.version from 1.12.22 to 1.13.0 (apache#11548) Bump byte-buddy from 1.12.22 to 1.13.0 (apache#11550) Bump maven-plugin-api from 3.8.7 to 3.9.0 (apache#11551) Rename file cache to prevent being duplicated with CacheFilter (apache#11530) Fix hasPreparedInternalModule is always false. (apache#11535) (apache#11536) collect jacoco result (apache#11532) optimize MockDirInvocation setObjectAttachmentIfAbsent method code (apache#11527) Metrics Count Optimization (apache#11529) Tri grpc compatibility (apache#11544) Fix NPE when removing registry (apache#11514) # Conflicts: # dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/DefaultMetricsCollector.java # dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/stat/MetricsStatComposite.java
No description provided.