Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Count Optimization #11529

Merged
merged 14 commits into from
Feb 13, 2023
Merged

Metrics Count Optimization #11529

merged 14 commits into from
Feb 13, 2023

Conversation

jojocodeX
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Merging #11529 (d7e9016) into 3.2 (cc32ebe) will decrease coverage by 4.86%.
The diff coverage is 89.05%.

❗ Current head d7e9016 differs from pull request most recent head 7dd8090. Consider uploading reports for the commit 7dd8090 to get more accurate results

@@             Coverage Diff              @@
##                3.2   #11529      +/-   ##
============================================
- Coverage     69.67%   64.81%   -4.86%     
+ Complexity      119       14     -105     
============================================
  Files          1561     1514      -47     
  Lines         83705    62911   -20794     
  Branches      14924     9180    -5744     
============================================
- Hits          58323    40778   -17545     
+ Misses        20500    17898    -2602     
+ Partials       4882     4235     -647     
Impacted Files Coverage Δ
...a/org/apache/dubbo/metrics/event/MetricsEvent.java 82.35% <ø> (ø)
...g/apache/dubbo/metrics/model/ThreadPoolMetric.java 0.00% <ø> (-18.19%) ⬇️
...o/metrics/collector/AggregateMetricsCollector.java 94.80% <ø> (+2.59%) ⬆️
...ics/collector/sample/ThreadPoolMetricsSampler.java 55.55% <55.55%> (ø)
...dubbo/metrics/filter/MethodMetricsInterceptor.java 85.71% <88.23%> (ø)
...cs/collector/sample/SimpleMetricsCountSampler.java 92.53% <92.53%> (ø)
...bbo/metrics/collector/DefaultMetricsCollector.java 95.00% <93.10%> (-0.10%) ⬇️
...collector/sample/MetricsCountSampleConfigurer.java 94.44% <94.44%> (ø)
...ubbo/config/deploy/DefaultApplicationDeployer.java 72.69% <100.00%> (-9.27%) ⬇️
...metrics/collector/sample/MethodMetricsSampler.java 100.00% <100.00%> (ø)
... and 509 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ
Copy link
Member

@songxiaosheng PTAL

# Conflicts:
#	dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/DefaultMetricsCollector.java
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

84.0% 84.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit bef06c8 into apache:3.2 Feb 13, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 14, 2023
* 3.2:
  Bump maven-assembly-plugin from 3.1.0 to 3.4.2 (apache#11547)
  Bump consul-api from 1.4.2 to 1.4.5 (apache#11545)
  Bump maven-core from 3.8.7 to 3.9.0 (apache#11546)
  Bump bytebuddy.version from 1.12.22 to 1.13.0 (apache#11548)
  Bump byte-buddy from 1.12.22 to 1.13.0 (apache#11550)
  Bump maven-plugin-api from 3.8.7 to 3.9.0 (apache#11551)
  Rename file cache to prevent being duplicated with CacheFilter (apache#11530)
  Fix hasPreparedInternalModule is always false. (apache#11535) (apache#11536)
  collect jacoco result (apache#11532)
  optimize MockDirInvocation setObjectAttachmentIfAbsent method code (apache#11527)
  Metrics Count Optimization (apache#11529)
  Tri grpc compatibility (apache#11544)
  Fix NPE when removing registry (apache#11514)

# Conflicts:
#	dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/DefaultMetricsCollector.java
#	dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/stat/MetricsStatComposite.java
@jojocodeX jojocodeX deleted the me-3.2-beta-metrics branch February 15, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants