[Bug](column) fix append_data_by_selector_impl reserve too mush useless memory #39581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zhangstar333
changed the title
|
run buildall |
yiguolei
reviewed
Aug 19, 2024
be/src/vec/columns/column_impl.h
Outdated
|
|
||
| res->reserve(num_rows); | ||
| DCHECK_GE(end, begin); | ||
| res->reserve(end - begin); |
There was a problem hiding this comment.
add comment here to explain why need using this variable to reserve memory not using num rows
TPC-H: Total hot run time: 38420 ms |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 38573 ms |
TPC-DS: Total hot run time: 190611 ms |
ClickBench: Total hot run time: 31.25 s |
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Aug 20, 2024
…ss memory (apache#39581) ## Proposed changes ``` for (auto* place : local_state._value_places) { SCOPED_TIMER(local_state._selector_block_timer); RETURN_IF_ERROR(place->append_block_by_selector(input_block, eos)); } for (int i = 0; i < mutable_columns.size(); ++i) { columns[i]->append_data_by_selector(mutable_columns[i], _selector); } ``` the columns[I] size is 4096, and _selector size is 1; so the (4096 - 1) rows is useless; in a usercase, the block have 4096 rows and 34 columns. so need bytes is: 1 block * 4096 rows * 4096 reserve * 16 bytes * 34 column * 48 instance = 438086664192 bytes; it's will cause the query canceled as not have enough memory.
dataroaring
pushed a commit
that referenced
this pull request
Aug 26, 2024
…ss memory (#39581) ## Proposed changes ``` for (auto* place : local_state._value_places) { SCOPED_TIMER(local_state._selector_block_timer); RETURN_IF_ERROR(place->append_block_by_selector(input_block, eos)); } for (int i = 0; i < mutable_columns.size(); ++i) { columns[i]->append_data_by_selector(mutable_columns[i], _selector); } ``` the columns[I] size is 4096, and _selector size is 1; so the (4096 - 1) rows is useless; in a usercase, the block have 4096 rows and 34 columns. so need bytes is: 1 block * 4096 rows * 4096 reserve * 16 bytes * 34 column * 48 instance = 438086664192 bytes; it's will cause the query canceled as not have enough memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
the columns[I] size is 4096, and _selector size is 1;
so the (4096 - 1) rows is useless;
in a usercase, the block have 4096 rows and 34 columns.
so need bytes is:
1 block * 4096 rows * 4096 reserve * 16 bytes * 34 column * 48 instance = 438086664192 bytes;
it's will cause the query canceled as not have enough memory.