Skip to content

Commit

Permalink
[cherry-pick](branch-21) fix append_data_by_selector_impl reserve too…
Browse files Browse the repository at this point in the history
… mush useless memory (#39581) (#39635)

## Proposed changes

cherry-pick from master #39581
  • Loading branch information
zhangstar333 authored Aug 21, 2024
1 parent 75eded0 commit 7bb83ae
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions be/src/vec/columns/column_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,11 @@ void IColumn::append_data_by_selector_impl(MutablePtr& res, const Selector& sele
"Size of selector: {} is larger than size of column: {}",
selector.size(), num_rows);
}

res->reserve(num_rows);
DCHECK_GE(end, begin);
// here wants insert some value from this column, and the nums is (end - begin)
// and many be this column num_rows is 4096, but only need insert num is (1 - 0) = 1
// so can't call res->reserve(num_rows), it's will be too mush waste memory
res->reserve(res->size() + (end - begin));

for (size_t i = begin; i < end; ++i) {
static_cast<Derived&>(*res).insert_from(*this, selector[i]);
Expand Down

0 comments on commit 7bb83ae

Please sign in to comment.