[Bug](partition-topn) fix partition-topn calculate partition input rows have error #39100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39129 ms |
TPC-DS: Total hot run time: 201782 ms |
ClickBench: Total hot run time: 30.02 s |
|
run buildall |
TPC-H: Total hot run time: 39041 ms |
TPC-DS: Total hot run time: 204083 ms |
ClickBench: Total hot run time: 30.87 s |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
BiteTheDDDDt
approved these changes
Aug 9, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
…ws have error (#39100) 1. fix the _sorted_partition_input_rows calculate have error, it's should only update the rows which have been emplace into hash table, not include the rows which is pass through. 2. add some counter in profile could get some info of about input/output rows have been do partition-topn.
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Aug 13, 2024
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
…ws have error (apache#39100) 1. fix the _sorted_partition_input_rows calculate have error, it's should only update the rows which have been emplace into hash table, not include the rows which is pass through. 2. add some counter in profile could get some info of about input/output rows have been do partition-topn.
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
…ws have error (#39100) 1. fix the _sorted_partition_input_rows calculate have error, it's should only update the rows which have been emplace into hash table, not include the rows which is pass through. 2. add some counter in profile could get some info of about input/output rows have been do partition-topn.
HappenLee
pushed a commit
that referenced
this pull request
Aug 31, 2024
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Oct 17, 2024
…ws have error (apache#39100) 1. fix the _sorted_partition_input_rows calculate have error, it's should only update the rows which have been emplace into hash table, not include the rows which is pass through. 2. add some counter in profile could get some info of about input/output rows have been do partition-topn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix the _sorted_partition_input_rows calculate have error, it's should only update the rows which have been emplace into hash table, not include the rows which is pass through.
add some counter in profile could get some info of about input/output rows have been do partition-topn.