Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] Correcting the documentation regarding lefttoright option information #648

Merged
merged 1 commit into from
Mar 25, 2020
Merged

[android] Correcting the documentation regarding lefttoright option information #648

merged 1 commit into from
Mar 25, 2020

Conversation

mosabab
Copy link
Contributor

@mosabab mosabab commented Mar 19, 2020 •
edited
Loading

Platforms affected

Android

Motivation and Context

The current documentation for lefttoright option was wrong.

Description

The current information in the documentation about lefttoright option was wrote in wrong information as comparing it to the real situation for the current settings.

** WRONG INFORMATION:

lefttoright: Set to yes to swap positions of the navigation buttons and the close button. Specifically, navigation buttons go to the left and close button to the right.

** CORRECTED INFORMATION:

lefttoright: Set to yes to swap positions of the navigation buttons and the close button. Specifically, navigation buttons go to the right and close button to the left. Default value is no.

Testing

You can test it in any android devices using any versions.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@mosabab mosabab changed the title [android] Correcting the information regarding lefttoright option [android] Correcting the documentation regarding lefttoright option information Mar 19, 2020
@mosabab
Copy link
Contributor Author

mosabab commented Mar 23, 2020

@timbru31 could you please check this

@timbru31
Copy link
Member

Yes, I'll try to check this today. Could you provide some screenshots with the lefttoright option set to yes and no?

@mosabab
Copy link
Contributor Author

mosabab commented Mar 25, 2020

Yes, I'll try to check this today. Could you provide some screenshots with the lefttoright option set to yes and no?

There is no needs for screenshots, you can test it from your side and see the results.

README.md file documentation for this option lefttoright was written in wrong information.

As current documentation for this plugin (wrong information):

lefttoright: Set to yes to swap positions of the navigation buttons and the close button. Specifically, navigation buttons go to the left and close button to the right.

******* BUT *******
If you set yes you will see the opposite situation in real testing. (navigation buttons go to the right and close button to the left).

So, I created this pull just to correct the information regarding this option lefttoright for Android.

This pull is to swap information regarding this option.

@timbru31 timbru31 self-assigned this Mar 25, 2020
timbru31
timbru31 approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, my test showed that the README indeed swapped left and right.

@timbru31 timbru31 merged commit 0e5f05c into apache:master Mar 25, 2020
@timbru31 timbru31 mentioned this pull request Mar 25, 2020
Merged
5 tasks
expertanswerz pushed a commit to expertanswerz/cordova-plugin-inappbrowser that referenced this pull request Apr 9, 2020
@ChanchleshSuryawanshi
Merge branch 'master' into 3.2.x
54528fb 
* master:
  docs: replaces outdated transition and presentation style links (apache#662)
  chore: remove deprecated orientation methods (apache#666)
  Fix incorrect TypeScript typings (apache#515)
  [apacheGH-652] add check for openInSystem postNotification (apache#654)
  ci: updates Node.js versions (apache#659)
  chore(npm): improve ignore list (apache#658)
  fix(android): Reset lefttoright if not set (apache#442)
  [android] Correcting the documentation regarding lefttoright opt… (apache#648)
  (android) Added option to turn on/off fullscreen mode in Android (apache#634)
  Android apacheGH-470 InAppBrowser: java.lang.IllegalArgumentException (apache#616)
  breaking(ios): remove UIWebView (apache#635)
  chore(release): 3.2.1-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbru31 timbru31 timbru31 approved these changes

Assignees

@timbru31 timbru31

Labels
platform: android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosabab @timbru31