Fix incorrect TypeScript typings #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbru31
requested changes
Aug 1, 2019
types/index.d.ts
Outdated
| @@ -6,7 +6,7 @@ | |||
| // Copyright (c) Microsoft Open Technologies Inc | |||
| // Licensed under the MIT license. | |||
| // TypeScript Version: 2.3 | |||
| type channel = "loadstart" | "loadstop" | "loaderror" | "exit" | "message"; | |||
| type channel = "loadstart" | "loadstop" | "loaderror" | "exit" | "message" | string; | |||
There was a problem hiding this comment.
this makes the type useless if we just use a string. Let's continue the discussion in #514 where I've added a question.
|
Updated to an agreed solution in #514 |
expertanswerz
pushed a commit
to expertanswerz/cordova-plugin-inappbrowser
that referenced
this pull request
Apr 9, 2020
* master: docs: replaces outdated transition and presentation style links (apache#662) chore: remove deprecated orientation methods (apache#666) Fix incorrect TypeScript typings (apache#515) [apacheGH-652] add check for openInSystem postNotification (apache#654) ci: updates Node.js versions (apache#659) chore(npm): improve ignore list (apache#658) fix(android): Reset lefttoright if not set (apache#442) [android] Correcting the documentation regarding lefttoright opt… (apache#648) (android) Added option to turn on/off fullscreen mode in Android (apache#634) Android apacheGH-470 InAppBrowser: java.lang.IllegalArgumentException (apache#616) breaking(ios): remove UIWebView (apache#635) chore(release): 3.2.1-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
TypeScript based Cordova projects.
Motivation and Context
Fixes #514.
Description
There was a regression in 3.1.0 since 3.0.0, whereby typings did not allow for an arbitrary
stringtype for event listeners. In case your TypeScript project contains anything else extendingWindow, it would cause the build to fail.Testing
Ran official 3.1.0 from apache, build failures as described in linked issue.
Ran this fork, build succeeds.
Checklist
(platform)if this change only applies to one platform (e.g.(android))