ARTEMIS-4955 Support broker properties from JSON files #5120
Conversation
|
I think it could be nicer to use an extension=type setup to convey what type of config is being used, rather than using broker.properties files for different types of config, so e.g. perhaps broker.json in this case. Seems more obvious for now in terms of what is being used at any given time, and more open to addition later for other specific types at some point? E.g. think of the log4j config as example. |
|
@gemmellr your suggestion sounds good to me. I have just pushed a commit to implement that. |
| private void parseFileProperties(File file) throws Exception { | ||
| InsertionOrderedProperties brokerProperties = new InsertionOrderedProperties(); | ||
| try (FileReader fileReader = new FileReader(file); | ||
| BufferedReader reader = new BufferedReader(fileReader)) { | ||
| if (file.getName().endsWith(".json")) { | ||
| brokerProperties.loadJson(reader); | ||
| } else { | ||
| brokerProperties.load(reader); | ||
| } | ||
| } | ||
|
|
||
| parsePrefixedProperties(this, file.getName(), brokerProperties, null); | ||
| } | ||
|
|
There was a problem hiding this comment.
@brusdev we don't have an openapi definition for the broker properties atm, but when we start to having one, we could easily add a validation step upon reading the file to ensure that any properties we're loading is valid according to the spec.
No description provided.