ARTEMIS-4909 use names that match original xml tags #5075
Conversation
|
This all seems to assume that the config is only coming from the XML tags, which actually isnt necessarily the case, so it feels like this should stay more general as it currently is. |
| @@ -4689,11 +4689,11 @@ private static void setUnsetQueueParamsToDefaults(QueueConfiguration c) { | |||
|
|
|||
| private void deployReloadableConfigFromConfiguration() throws Exception { | |||
| if (configurationReloadDeployed.compareAndSet(false, true)) { | |||
| ActiveMQServerLogger.LOGGER.reloadingConfiguration("security"); | |||
| ActiveMQServerLogger.LOGGER.reloadingConfiguration("security-settings"); | |||
There was a problem hiding this comment.
I could see making this "security settings", i.e adding " settings" to make it consistent with the "address settings" one below (which would remain as it was), but I dont think they should strictly match the XML tags since that may in fact not be where the configuration is coming from.
|
Some more context here... The broker currently supports configuration via XML, properties, and the management API. JSON support was also recently added. All of these use some variant of the words "security," "address," and "settings" together, and I think it's reasonable for the log to use wording consistent with this. However, the wording in the log doesn't need to be exactly the same as the XML. I recommend you keep |
|
thank for your comments. I'll update the PR with Justin's suggestion. |
erwindon
force-pushed
the
ARTEMIS-4909_reload_conf_names
branch
from
55fc435
to
ecab2fd
Compare
|
PR is updated (and rebased) |
|
@erwindon, thanks! |
see https://issues.apache.org/jira/browse/ARTEMIS-4909