Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update control 1.1.6 #44

Merged
merged 35 commits into from
Jun 19, 2024
Merged

Conversation

mfortin
Copy link
Contributor

@mfortin mfortin commented May 2, 2024

Overall Review of Changes:
Control 1.1.6 can't be applied right now

TASK [Windows-2022-CIS : 1.1.6 | PATCH | Ensure Relax minimum password length limits is set to Enabled.] ***
fatal: [10.0.0.137]: FAILED! => changed=true
  import_log: |-
    Completed 1 percent (0/63)      Process Privilege Rights area
    Completed 3 percent (1/63)      Process Privilege Rights area
    Completed 4 percent (2/63)      Process Privilege Rights area
    Completed 6 percent (3/63)      Process Privilege Rights area
    Completed 7 percent (4/63)      Process Privilege Rights area
    Completed 9 percent (5/63)      Process Privilege Rights area
    Completed 11 percent (6/63)     Process Privilege Rights area
    Completed 12 percent (7/63)     Process Privilege Rights area
    Completed 14 percent (8/63)     Process Privilege Rights area
    Completed 15 percent (9/63)     Process Privilege Rights area
    Completed 17 percent (10/63)    Process Privilege Rights area
    Completed 19 percent (11/63)    Process Privilege Rights area
    Completed 20 percent (12/63)    Process Privilege Rights area
    Completed 25 percent (15/63)    Process Privilege Rights area
    Completed 25 percent (15/63)    Process Group Membership area
    Completed 49 percent (30/63)    Process Group Membership area
    Completed 49 percent (30/63)    Process Registry Keys area
    Completed 49 percent (30/63)    Process File Security area
    Completed 49 percent (30/63)    Process Services area
    Completed 65 percent (40/63)    Process Services area
    Completed 73 percent (45/63)    Process Services area
    Completed 73 percent (45/63)    Process Security Policy area
    Completed 77 percent (48/63)    Process Security Policy area
    Completed 84 percent (52/63)    Process Security Policy area
    Completed 88 percent (55/63)    Process Security Policy area
    Completed 93 percent (58/63)    Process Security Policy area
    Completed 100 percent (63/63)   Process Security Policy area
    The task has completed successfully.
  key: RelaxMinimumPasswordLengthLimits
  msg: The key 'RelaxMinimumPasswordLengthLimits' in section 'System Access' is not a valid key, cannot set this value
  section: System Access
  value: 1

Issue Fixes:
No issues created

Enhancements:
Enforces control id 1.1.6

How has this been tested?:
Locally, on an EC2 instance.

frederickw082922 and others added 30 commits April 16, 2024 12:08
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
frederickw082922 and others added 2 commits April 16, 2024 12:08
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
@mfortin mfortin force-pushed the control-1.1.6 branch 2 times, most recently from bad5e91 to ba2412e Compare May 2, 2024 23:15
@mfortin
Copy link
Contributor Author

mfortin commented Jun 5, 2024

@frederickw082922 can you restart this test build ?

@frederickw082922 frederickw082922 self-requested a review June 5, 2024 21:34
@frederickw082922
Copy link
Contributor

@mfortin Thank you for the PR! Do not see the re-run workflow button on the validation. Not sure if actions/checkout@v3 has anything to do with it since there is an actions/checkout@v4.

CC: @MrSteve81

@mfortin
Copy link
Contributor Author

mfortin commented Jun 6, 2024

@frederickw082922 I applied a simple commit to do the rebuild, it worked...

Copy link
Contributor

@frederickw082922 frederickw082922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thank you @mfortin ! Good find! CC: @MrSteve81

MrSteve81
MrSteve81 previously approved these changes Jun 18, 2024
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Signed-off-by: fortinm <mathieu.fortin@autodesk.com>
Signed-off-by: Math Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Math Fortin <mathieu.fortin@autodesk.com>
Copy link
Contributor

@frederickw082922 frederickw082922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mfortin !

Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@frederickw082922 frederickw082922 merged commit 09d56c8 into ansible-lockdown:devel Jun 19, 2024
3 checks passed
@mfortin mfortin deleted the control-1.1.6 branch June 19, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants