Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import_tasks section18.yml has wrong when statement #32

Open
RomainPisters opened this issue Mar 23, 2024 · 2 comments
Open

import_tasks section18.yml has wrong when statement #32

RomainPisters opened this issue Mar 23, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@RomainPisters
Copy link

Describe the Issue
The main tasks file Windows-2022-CIS/tasks/main.yml has import_tasks tasks and when statements for each CIS section. I noticed task related to importing section 18 tasks uses the when statement for section 17.

- name: Execute the section 18 tasks
  ansible.builtin.import_tasks:
      file: section18.yml
  when:
      - win22cis_section17
  tags:
      - section18

Expected Behavior
When the variable win22cis_section18 is set to false, section18.yml shouldn't be included in the play.

Actual Behavior
A clear and concise description of what's happening.

Control(s) Affected
What controls are being affected by the issue

Environment (please complete the following information):
Additional Notes
Anything additional goes here

Possible Solution

- name: Execute the section 18 tasks
  ansible.builtin.import_tasks:
      file: section18.yml
  when:
      - win22cis_section18
  tags:
      - section18
@RomainPisters RomainPisters added the bug Something isn't working label Mar 23, 2024
@frederickw082922 frederickw082922 self-assigned this Apr 1, 2024
@frederickw082922
Copy link
Contributor

Thank you @RomainPisters

Nice catch!

CC: @georgenalen , @MrSteve81

frederickw082922 added a commit that referenced this issue Apr 1, 2024
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
frederickw082922 added a commit that referenced this issue Apr 1, 2024
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
frederickw082922 added a commit that referenced this issue Apr 5, 2024
mfortin pushed a commit to mfortin/Windows-2022-CIS that referenced this issue Apr 16, 2024
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
mfortin pushed a commit to mfortin/Windows-2022-CIS that referenced this issue Apr 16, 2024
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
mfortin pushed a commit to mfortin/Windows-2022-CIS that referenced this issue Apr 16, 2024
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
mfortin pushed a commit to mfortin/Windows-2022-CIS that referenced this issue Apr 16, 2024
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
@frederickw082922
Copy link
Contributor

Fixed in PR #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants