Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KV get fixups #264

Merged
merged 3 commits into from
May 3, 2022
Merged

Conversation

briantist
Copy link
Collaborator

SUMMARY

Fixes #258
Fixes #246 (comment)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vault_kv1_get
vault_kv2_get
vault_pki_generate_certificate

ADDITIONAL INFORMATION

The new plugins are not released yet, so there is no breaking change or changelog frragment needed.

@briantist briantist added the bug Something isn't working label May 1, 2022
@briantist briantist added this to the v2.5.0 milestone May 1, 2022
@briantist briantist self-assigned this May 1, 2022
@github-actions
Copy link

github-actions bot commented May 1, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.hashi_vault/branch/main

@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #264 (6aa57ba) into main (54c81ef) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          66       66           
  Lines        3208     3208           
  Branches      267      267           
=======================================
  Hits         3155     3155           
  Misses         44       44           
  Partials        9        9           
Flag Coverage Δ
env_docker-default 98.34% <100.00%> (ø)
integration 81.03% <100.00%> (ø)
sanity 39.88% <0.00%> (ø)
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 80.84% <100.00%> (ø)
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 39.88% <0.00%> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_kv1_get 91.30% <100.00%> (ø)
target_lookup_vault_kv2_get 91.11% <100.00%> (ø)
target_lookup_vault_login 88.57% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 78.18% <ø> (ø)
target_lookup_vault_write 59.14% <ø> (ø)
target_module_utils 97.24% <ø> (ø)
target_module_vault_kv1_get 87.23% <100.00%> (ø)
target_module_vault_kv2_get 86.95% <100.00%> (ø)
target_module_vault_login 83.33% <ø> (ø)
target_module_vault_pki_generate_certificate 78.26% <ø> (ø)
target_module_vault_read 85.36% <ø> (ø)
target_module_vault_token_create 90.00% <ø> (ø)
target_module_vault_write 57.53% <ø> (ø)
target_modules 79.08% <100.00%> (ø)
units 95.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/doc_fragments/engine_mount.py 100.00% <ø> (ø)
plugins/modules/vault_pki_generate_certificate.py 95.65% <ø> (ø)
plugins/lookup/vault_kv1_get.py 100.00% <100.00%> (ø)
plugins/lookup/vault_kv2_get.py 100.00% <100.00%> (ø)
plugins/modules/vault_kv1_get.py 100.00% <100.00%> (ø)
plugins/modules/vault_kv2_get.py 100.00% <100.00%> (ø)
tests/unit/plugins/lookup/test_vault_kv1_get.py 100.00% <100.00%> (ø)
tests/unit/plugins/lookup/test_vault_kv2_get.py 100.00% <100.00%> (ø)
tests/unit/plugins/modules/test_vault_kv1_get.py 100.00% <100.00%> (ø)
tests/unit/plugins/modules/test_vault_kv2_get.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c81ef...6aa57ba. Read the comment docs.

@briantist
Copy link
Collaborator Author

@felixfontein thank you for reviewing!

@briantist briantist merged commit 975d4d6 into ansible-collections:main May 3, 2022
@briantist briantist deleted the content/kv-fixups branch May 3, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The vault_kv*_get content uses backend_mount_point but vault_pki_generate_certificate uses engine_mount_point
2 participants