add content for KV get operations #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 97.49% 97.94% +0.44%
==========================================
Files 56 65 +9
Lines 2518 3060 +542
Branches 241 268 +27
==========================================
+ Hits 2455 2997 +542
Misses 49 49
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This was referenced Apr 24, 2022
felixfontein
approved these changes
Apr 28, 2022
|
thanks for taking a look @felixfontein ! |
lowlydba
reviewed
Apr 30, 2022
Comment on lines
+125
to
+128
| custom_metadata": null | ||
| deletion_time": "" | ||
| destroyed": false | ||
| version": 2 |
There was a problem hiding this comment.
Super late, but are these missing opening quotes?
There was a problem hiding this comment.
I think it's more that they have closing quotes that shouldn't be there :-)
This is actually valid YAML (just checked), you get a dictionary where the keys end with ". Which is likely not what the API returns.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding modules and lookups for KV get.
I started with a single
vault_kv_getthat would take akv_versionoption to decide which KV version we're dealing with, but ultimately decided on separate modules/plugins for kv1 and kv2: both the inputs (options) and outputs (return data) are different, so trying to mix them doesn't make a lot of sense.I have mulled over the possibility of a generic
vault_kv_getin addition that could A) take akv_version, B) read the mount point info from Vault to determine which KV version it is (extra round trip + requires permissions), or C) both (likekv_versioncould be1,2, or'auto'). I am still not so sure this "generic" one is a good idea. I won't be implementing it in this PR, but if there's demand we'll have a public discussion about it.ISSUE TYPE
COMPONENT NAME
vault_kv1_get (lookup & module)
vault_kv2_get (lookup & module)
ADDITIONAL INFORMATION
[Feedback Wanted] upcoming kv modules, path, and mount_point #229
Resolves hashi_vault should support secret v2 path (without adding /data/) #9
Fixes several modules are missing from the action group #251