Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module - ec2_vpc_endpoint_service_info #346

Merged
merged 5 commits into from
Mar 19, 2021
Merged

New module - ec2_vpc_endpoint_service_info #346

merged 5 commits into from
Mar 19, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 5, 2021 •
edited
Loading

SUMMARY

Split the querying of service out of ec2_vpc_endpoint_info and support pulling detailed information

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ec2_vpc_endpoint_service_info
ec2_vpc_endpoint_info

ADDITIONAL INFORMATION

Todo:

@tremble tremble changed the title New module - ec2_vpc_endpoint_service_info [WIP] New module - ec2_vpc_endpoint_service_info Jan 5, 2021
@ansibullbot
Copy link

cc @Etherdaemon @jillr @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Jan 13, 2021
jillr
jillr reviewed Jan 14, 2021
View reviewed changes
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Policy is deployed. Couple tiny things and needs the changelog otherwise lgtm, thanks @tremble

plugins/modules/ec2_vpc_endpoint_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_endpoint_service_info.py Outdated Show resolved Hide resolved
@tremble tremble force-pushed the ec2_vpc_endpoint_service_info branch from f55b32f to ce64a6b Compare January 15, 2021 13:40
@tremble tremble changed the title [WIP] New module - ec2_vpc_endpoint_service_info New module - ec2_vpc_endpoint_service_info Jan 15, 2021
@tremble tremble requested a review from jillr January 15, 2021 13:42
@tremble tremble removed the WIP Work in progress label Jan 19, 2021
jillr
jillr approved these changes Feb 19, 2021
View reviewed changes
plugins/modules/ec2_vpc_endpoint_service_info.py Outdated Show resolved Hide resolved
@tremble tremble mentioned this pull request Feb 20, 2021
Merged
@jillr jillr merged commit b48c1ee into ansible-collections:main Mar 19, 2021
@tremble tremble deleted the ec2_vpc_endpoint_service_info branch June 29, 2021 12:55
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
@tremble @jillr
[promoted]New module - ec2_vpc_endpoint_service_info (ansible-collect…
a7f6428 
…ions#346)

* New module - ec2_vpc_endpoint_service_info

* Deprecate querying services through ec2_vpc_endpoint_info

* Attempt to cope with some services which have who possible endpoints

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b48c1ee
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@tremble @jillr
New module - ec2_vpc_endpoint_service_info (ansible-collections#346)
d44c892 
* New module - ec2_vpc_endpoint_service_info

* Deprecate querying services through ec2_vpc_endpoint_info

* Attempt to cope with some services which have who possible endpoints

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@tremble @jillr
New module - ec2_vpc_endpoint_service_info (ansible-collections#346)
0d0a297 
* New module - ec2_vpc_endpoint_service_info

* Deprecate querying services through ec2_vpc_endpoint_info

* Attempt to cope with some services which have who possible endpoints

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
@tremble @jillr @danielcotton
New module - ec2_vpc_endpoint_service_info (ansible-collections#346)
cbcaba3 
* New module - ec2_vpc_endpoint_service_info

* Deprecate querying services through ec2_vpc_endpoint_info

* Attempt to cope with some services which have who possible endpoints

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble
ec2_vol: Limit the scope of new botocore requirements (ansible-collec…
d25dfd8 
…tions#346)

ec2_vol: Limit the scope of new botocore requirements

Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble @jillr @alinabuzachis
New module - ec2_vpc_endpoint_service_info (ansible-collections#346)
2dade29 
* New module - ec2_vpc_endpoint_service_info

* Deprecate querying services through ec2_vpc_endpoint_info

* Attempt to cope with some services which have who possible endpoints

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b48c1ee
@tremble tremble mentioned this pull request Oct 18, 2022
Closed
1 task
@tremble tremble mentioned this pull request Jan 2, 2023
Merged
softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Jan 9, 2023
@tremble
[6.0.0] ec2_vpc_endpoint_info - Drop support for query (#1308)
14b8d70 
[6.0.0] ec2_vpc_endpoint_info - Drop support for `query`

SUMMARY
fixes: #1179
Original deprecation: ansible-collections/community.aws#346
While "VPC Endpoint Services" are related to endpoints, they're separate resources.  As such ec2_vpc_endpoint_service_info was split off in ansible-collections/community.aws#346
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_endpoint_info
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
community_review integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @jillr