Skip to content

Commit

Permalink
review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
tremble committed Jan 15, 2021
1 parent b8b652b commit ce64a6b
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
6 changes: 6 additions & 0 deletions changelogs/fragments/346-ec2_vpc_endpoint_service_info.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
minor_changes:
- ec2_vpc_endpoint_service_info - new module added for fetching information about available VPC endpoint services (https://github.com/ansible-collections/community.aws/pull/346).
deprecated_features:
- ec2_vpc_endpoint_info - the ``query`` option has been deprecated and will be removed after 2022-12-01 (https://github.com/ansible-collections/community.aws/pull/346).
The ec2_vpc_endpoint_info now defaults to listing information about endpoints.
The ability to search for information about available services has been moved to the dedicated module ``ec2_vpc_endpoint_service_info``.
5 changes: 4 additions & 1 deletion plugins/modules/ec2_vpc_endpoint_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,10 @@ def main():
query = module.params.get('query')
if query == 'endpoints':
module.deprecate('The query option has been deprecated and'
' will be removed after 2022-12-01',
' will be removed after 2022-12-01. Searching for'
' `endpoints` is now the default and after'
' 2022-12-01 this module will only support fetching'
' endpoints.',
date='2022-12-01', collection_name='community.aws')
elif query == 'services':
module.deprecate('Support for fetching service information with this '
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/ec2_vpc_endpoint_service_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
'''

EXAMPLES = r'''
# Simple example of listing all support AWS services for VPC endpoints
# Simple example of listing all supported AWS services for VPC endpoints
- name: List supported AWS endpoint services
community.aws.ec2_vpc_endpoint_service_info:
region: ap-southeast-2
Expand Down

0 comments on commit ce64a6b

Please sign in to comment.