Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1410/3d4736bb backport][stable-3] Minor sanity test fixes (new devel) #1498

Commits on Sep 19, 2022

  1. [PR ansible-collections#1410/3d4736bb backport][stable-3] Minor sanit…

    …y test fixes (new devel)
    
    **This is a backport of PR ansible-collections#1410 as merged into main (3d4736b).**
    
    ##### SUMMARY
    
    ansible-devel has added a new PEP test (missing whitespace after keyword), this adds the fixes before the devel sanity tests are 'voting'.
    
    Additionally fixes:
    - unused variables
    - broad catching of Exception
    
    ##### ISSUE TYPE
    
    Bugfix Pull Request
    
    ##### COMPONENT NAME
    
    plugins/modules/autoscaling_group_info.py
    plugins/modules/cloudfront_distribution.py
    plugins/modules/cloudfront_origin_access_identity.py
    plugins/modules/cloudtrail.py
    plugins/modules/ec2_vpc_nacl.py
    plugins/modules/eks_fargate_profile.py
    plugins/modules/redshift.py
    plugins/modules/s3_bucket_info.py
    
    ##### ADDITIONAL INFORMATION
    
    cloudfront_distribution still has a lot of catch Exception but it's part of parameter validation which should be overhauled separately, unfortunately the tests are rather b0rked.
    
    Reviewed-by: Alina Buzachis <None>
    tremble committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    05b2240 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Add ignore

    tremble committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    8a7f3f7 View commit details
    Browse the repository at this point in the history