[PR #1410/3d4736bb backport][stable-3] Minor sanity test fixes (new devel) #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
backports/stable-3/1410
branch
from
b9e3eb5
to
af21e5a
Compare
ansibullbot
added
bug
This comment was marked as resolved.
This comment was marked as resolved.
…y test fixes (new devel) **This is a backport of PR ansible-collections#1410 as merged into main (3d4736b).** ##### SUMMARY ansible-devel has added a new PEP test (missing whitespace after keyword), this adds the fixes before the devel sanity tests are 'voting'. Additionally fixes: - unused variables - broad catching of Exception ##### ISSUE TYPE Bugfix Pull Request ##### COMPONENT NAME plugins/modules/autoscaling_group_info.py plugins/modules/cloudfront_distribution.py plugins/modules/cloudfront_origin_access_identity.py plugins/modules/cloudtrail.py plugins/modules/ec2_vpc_nacl.py plugins/modules/eks_fargate_profile.py plugins/modules/redshift.py plugins/modules/s3_bucket_info.py ##### ADDITIONAL INFORMATION cloudfront_distribution still has a lot of catch Exception but it's part of parameter validation which should be overhauled separately, unfortunately the tests are rather b0rked. Reviewed-by: Alina Buzachis <None>
tremble
force-pushed
the
backports/stable-3/1410
branch
from
af21e5a
to
05b2240
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
backports/stable-3/1410
branch
from
6a5aeec
to
4292dbf
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
backports/stable-3/1410
branch
from
4292dbf
to
05b2240
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
backports/stable-3/1410
branch
from
e5ea78b
to
8a7f3f7
Compare
alinabuzachis
approved these changes
Sep 20, 2022
softwarefactory-project-zuul
bot
merged commit 665d058
into
ansible-collections:stable-3
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Add stable-* branch to GitHub Workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #1500
This is a backport of PR #1410 as merged into main (3d4736b).
SUMMARY
ansible-devel has added a new PEP test (missing whitespace after keyword), this adds the fixes before the devel sanity tests are 'voting'.
Additionally fixes:
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
plugins/modules/autoscaling_group_info.py
plugins/modules/cloudfront_distribution.py
plugins/modules/cloudfront_origin_access_identity.py
plugins/modules/cloudtrail.py
plugins/modules/ec2_vpc_nacl.py
plugins/modules/redshift.py
plugins/modules/s3_bucket_info.py
ADDITIONAL INFORMATION
cloudfront_distribution still has a lot of catch Exception but it's part of parameter validation which should be overhauled separately, unfortunately the tests are rather b0rked.
Reviewed-by: Alina Buzachis