Update dev guidelines - add return values guidelines #865
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 17s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 04s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s |
tremble
changed the title
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
jatorcasso
force-pushed
the
return_vals/docs_fragment
branch
from
ab364bc
to
03e223c
Compare
jatorcasso
changed the title
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 10m 31s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 29s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 03s |
tremble
changed the title
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 54s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 36s |
|
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
Co-authored-by: Mark Chappell <mchappel@redhat.com>
jatorcasso
force-pushed
the
return_vals/docs_fragment
branch
from
4e2014d
to
209756b
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 56s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 27s |
…collections#865) Add AWSRetry backoff logic to route53_zone and route53_info SUMMARY Add AWSRetry backoff logic to route53_zone and route53_info. Currently from time to time I've been hitting AWS throttling errors leading to ansible failures: An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded fatal: [localhost_staging -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Could not list current hosted zones: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: connection: close content-length: '255' content-type: text/xml date: Fri, 14 Jan 2022 12:09:35 GMT x-amzn-requestid: xxxxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_zone route53_info ADDITIONAL INFORMATION I've added the standard backoff retry logic and split out the paginators. Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ca1d33f
…collections#865) Add AWSRetry backoff logic to route53_zone and route53_info SUMMARY Add AWSRetry backoff logic to route53_zone and route53_info. Currently from time to time I've been hitting AWS throttling errors leading to ansible failures: An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded fatal: [localhost_staging -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Could not list current hosted zones: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: connection: close content-length: '255' content-type: text/xml date: Fri, 14 Jan 2022 12:09:35 GMT x-amzn-requestid: xxxxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_zone route53_info ADDITIONAL INFORMATION I've added the standard backoff retry logic and split out the paginators. Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ca1d33f
…collections#865) Add AWSRetry backoff logic to route53_zone and route53_info SUMMARY Add AWSRetry backoff logic to route53_zone and route53_info. Currently from time to time I've been hitting AWS throttling errors leading to ansible failures: An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded fatal: [localhost_staging -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Could not list current hosted zones: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: connection: close content-length: '255' content-type: text/xml date: Fri, 14 Jan 2022 12:09:35 GMT x-amzn-requestid: xxxxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_zone route53_info ADDITIONAL INFORMATION I've added the standard backoff retry logic and split out the paginators. Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ca1d33f
…collections#865) Add AWSRetry backoff logic to route53_zone and route53_info SUMMARY Add AWSRetry backoff logic to route53_zone and route53_info. Currently from time to time I've been hitting AWS throttling errors leading to ansible failures: An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded fatal: [localhost_staging -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Could not list current hosted zones: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: connection: close content-length: '255' content-type: text/xml date: Fri, 14 Jan 2022 12:09:35 GMT x-amzn-requestid: xxxxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_zone route53_info ADDITIONAL INFORMATION I've added the standard backoff retry logic and split out the paginators. Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ca1d33f
…collections#865) Add AWSRetry backoff logic to route53_zone and route53_info SUMMARY Add AWSRetry backoff logic to route53_zone and route53_info. Currently from time to time I've been hitting AWS throttling errors leading to ansible failures: An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded fatal: [localhost_staging -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Could not list current hosted zones: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: connection: close content-length: '255' content-type: text/xml date: Fri, 14 Jan 2022 12:09:35 GMT x-amzn-requestid: xxxxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_zone route53_info ADDITIONAL INFORMATION I've added the standard backoff retry logic and split out the paginators. Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
…collections#865) Add AWSRetry backoff logic to route53_zone and route53_info SUMMARY Add AWSRetry backoff logic to route53_zone and route53_info. Currently from time to time I've been hitting AWS throttling errors leading to ansible failures: An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded fatal: [localhost_staging -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Could not list current hosted zones: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: connection: close content-length: '255' content-type: text/xml date: Fri, 14 Jan 2022 12:09:35 GMT x-amzn-requestid: xxxxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_zone route53_info ADDITIONAL INFORMATION I've added the standard backoff retry logic and split out the paginators. Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
…collections#865) Add AWSRetry backoff logic to route53_zone and route53_info SUMMARY Add AWSRetry backoff logic to route53_zone and route53_info. Currently from time to time I've been hitting AWS throttling errors leading to ansible failures: An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded fatal: [localhost_staging -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Could not list current hosted zones: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: connection: close content-length: '255' content-type: text/xml date: Fri, 14 Jan 2022 12:09:35 GMT x-amzn-requestid: xxxxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_zone route53_info ADDITIONAL INFORMATION I've added the standard backoff retry logic and split out the paginators. Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
SUMMARY
As discussed in the last working group meeting. Updating the guidelines to create standards for what _info modules should return.
Items addressed:
boto3_tag_list_to_ansible_dictISSUE TYPE
COMPONENT NAME
docs/docsite/rst/dev_guidelines.rst