New Module: Amazon MQ #432
Conversation
ansibullbot
added
community_review
integration
|
I'll work on the code quality (sanity checks) |
|
Couple of quick comments:
|
Thank you for your hints. I'll take them into account |
fotto
force-pushed
the
mq
branch
4 times, most recently
from
95539ef
to
b11fcb8
Compare
|
current state:
not covered, yet:
How to proceed from here? |
|
@jillr wrote an initial guide: tests/integration/targets/iam_saml_federation/ includes a relatively simple example (but doesn't support check_mode) Biggest issue is likely to be IAM policies. |
|
@fotto this PR contains the following merge commits: Please rebase your branch to remove these commits. |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 55s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 31s |
|
regate |
|
regate |
|
regate |
remove trailing whitespace
fix docs
remove trailing white space
Co-authored-by: Alina Buzachis <abuzachis@redhat.com>
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 05s |
|
regate |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 33s |
New Module: Amazon MQ SUMMARY replicates ansible-collections/amazon.aws#266 as suggested This PR contains some basic support for Amazon MQ. It covers Managing Amazon MQ brokers Managing Amazon MQ configurations Managing Amazon MQ (local) users ISSUE TYPE New Module Pull Request COMPONENT NAME Amazon MQ ADDITIONAL INFORMATION We use those modules to manage our MQ Brokers. The context of usage is brokers are created by different means (e.g. terraform) - but the module is capable of doing that as well we've developed a custom role around those modules to manage MQ user credentials we use another local extension of amazon.aws collection (will come as separate PR) that interfaces with AWS SecretsManager that role uses the reboot broker feature (part of this PR) to implement a custom handler that reboots a broker whenever a configuration run sees any changes in configuration and/or users The functionality of the added modules is illustrated in the added test suite (tests/integration/targets/mq) some of them still require a running MQ broker to be usable. Missing functionality/limitations: requires a recent version of boto3 library (older versions don't support all Amazon MQ features used here) API results are returned "as is", i.e. there's no conversion from camel case yaml to snake yaml mq_broker.py no support for LDAP connection (external user management) update configuration only supported through mq_broker_config.py known to work only with EngineType=ACTIVEMQ (proper support for RABBITMQ still missing) mq_broker_config.py needs proper XML comparison between current and desired configuration (current one is too simplistic) only tested with ActiveMQ configurations Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
SUMMARY
replicates ansible-collections/amazon.aws#266 as suggested
This PR contains some basic support for Amazon MQ. It covers
ISSUE TYPE
COMPONENT NAME
Amazon MQ
ADDITIONAL INFORMATION
We use those modules to manage our MQ Brokers. The context of usage is
The functionality of the added modules is illustrated in the added test suite (tests/integration/targets/mq) some of them still require a running MQ broker to be usable.
Missing functionality/limitations:
mq_broker.py
mq_broker_config.py