2.1.66 and the removal of legacy schema support

[dae]

2.1.66 is not due out soon, but I thought I'd do this now while the proto gen changes are fresh in memory.

• Update the backend protobuf generation to match the refactoring done
  on the desktop code recently. This involved switching from the Python-based
  script to a new one in Rust. Comments from the proto files are now
  included in the generated backend bindings.

Also:

• Rumo contributed changes to the upstream Chrono crate which make
  it work properly on Android, and these changes have been merged in,
  so AnkiDroid no longer needs to pin an older version.
• Update to latest NDK, as latest Rust requires it (closes build(deps): bump ndk version to r24 #180 and Update NDK / native build tools to latest version #179).
• Update to latest Rust
• Update to Gradle 8, closes Errors shown when linting with check-droid #248, Update Gradle Wrapper from 6.8.3 to 7.6 #245, Update Gradle Wrapper from 6.8.3 to 7.5.1 #230, Update Gradle Wrapper from 6.8.3 to 7.4.2 #171
• Add a workaround for a crashing bug in the sim caused by the above.
  Needs testing to make sure building/running on macOS still works.
• Switch from protobuf to protobuf-lite, which is what Google recommend
  for use on Android.
• Add a script to make it easier to reformat Rust code when it fails
  checks.
• Plus more changes in the later commits

[dae]

So, unfortunately I hit a roadblock - Linux/Windows builds appear to be ok, but an x86_64 library built on a Mac fails to load in the emulator. I've rolled back the NDK and Rust version for now, which seems to have resolved the issue. I couldn't see any clear solution; hopefully we can revisit this in the future and the issue will be resolved or a clear workaround will be available.

[dae]

Bleh, another failure when cross compiling the Linux archives. Rolling back zstd or the bzip crate may help, but I've run out of time for now.

[dae]

Well that was a saga, but I think I'm getting there. The latest failure looks like it might be solved by bumping the minimum API to 23, which I'm trying now.

I've been meaning to bring up the supported versions actually - while it's noble to support older devices, given that AnkiDroid barely has enough developer resources as it is, I think it may be worth considering being a bit stricter about the version skew you're willing to support, especially as the tail end comprise only a tiny portion of the userbase. The low API target presumably also causes headaches with dependency updates on the non-backend side, and it's not like those users would suddenly be unable to use the app - it would just mean they'd lose access to updates until they're able to upgrade to a newer device. Thoughts?

[BrayanDSO]

21 + 22 is ~0,26% of our userbase, a pretty small and safe to cut number.

If it is something important that we can't workaround (e.g. dependencies) or that demands too much work to do, I'm all in favor of cutting older APIs (21 was released almost 10 years ago)

For the current release cycle, I think that we will be able to release 2.16 soon before having to make the API cut, so I'm quite confortable to remove those older APIs.

Pinging @mikehardy, as he may have some more thoughts about this

[mikehardy]

2.16 should go before making minsdkversion changes or merging this, which is just agreeing, if I understand correctly

Fast follows with moving a 2.17 that bumps minsdkver and this change and all sorts of other stuff I hope

[dae]

Finally green 😩

[dae]

RELEASE=1 performs subsets of the build under debug mode.

That's intended - we want the output artifacts to be built in release mode, but not build_rust, as building it in release mode would be slower than any minor runtime savings it might have.

[dae]

I'm not sure what's suddenly broken the build. Will investigate when I have a chance.

[dae]

I have no idea what happened there, but the upgrade seems to have fixed it. 🤷‍♂️

[mikehardy]

Testing note: I just ran through the buid on the M1 machine in the house, along with the corresponding Anki-Android build (using the coordinated PR there...) and ran ./gradlew jacocoTestReport and everything worked

So I think macOS apple silicon is ✅ now

I'll check intel mac and windows to make sure they're still good then approve...

[mikehardy]

worked for me on macos M1 + intel, as well as windows. I assume linux will work (it's tested in CI plus I think you use it @dae ?). I use it frequently as well, happy to help fuzzbust if I'm wrong about it working

[dae]

Yep, Linux is my main dev box again these days.

Thank you for the review!

[mikehardy]

Hey @dae - I don't think bisectability is such a concern there and I like just about every commit in the chain. Leaning towards rebase, but could squash. You have a preference? After that I'll publish likely tomorrow (nearly bedtime here now...)

[mikehardy]

I'll try to get a release out today, then I/we can modify the Anki-Android PR to point at the new artifact

[mikehardy]

What a huge improvement, wow! Thank you

[david-allison]

@dae (minor, don't spend time on it if it's not an instant answer)

Do you recall why buildConfig was removed in c495fd0

It compiled with the following, but don't know whether it was removed due to a problem downstream:

Subject: [PATCH] Bump version to 0.1.30-anki23.10.1
---
Index: rsdroid/build.gradle
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/rsdroid/build.gradle b/rsdroid/build.gradle
--- a/rsdroid/build.gradle	(revision 3dc1379468fc7f6322b7ddc79e080a516486b490)
+++ b/rsdroid/build.gradle	(date 1702053780640)
@@ -17,11 +17,22 @@
     return commit
 }
 
+def getAnkiDesktopVersion() {
+    Properties properties = new Properties()
+    properties.load(project.rootProject.file('gradle.properties').newDataInputStream())
+    def versionName = properties.getProperty('VERSION_NAME')
+    return versionName.substring(versionName.indexOf("anki") + "anki".length())
+}
+
 android {
     namespace 'net.ankiweb.rsdroid'
     compileSdk rootProject.ext.compileSdk
     ndkVersion "26.1.10909125" // Used by GitHub actions - avoids an install step on some machines
 
+    buildFeatures {
+        buildConfig true // expose 'ANKI_DESKTOP_VERSION'
+    }
+
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_11
         targetCompatibility JavaVersion.VERSION_11
@@ -34,6 +45,7 @@
         versionName VERSION_NAME
 
         consumerProguardFiles "consumer-rules.pro"
+        buildConfigField "String", "ANKI_DESKTOP_VERSION", "\"" + getAnkiDesktopVersion() + "\""
     }
 
     buildTypes {

[dae]

I believe it broke when Gradle was updated. If your changes or the passage of time got it working again, and you plan to use it, feel free to add it back.