-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stage name handling #579
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
9e86fea
Fix stage name handling
aoskotsky-amplify 5fa3b8a
support installing from git
aoskotsky-amplify 6d36152
AT-9828: More stage updates
rddimon faa66c7
Merge branch 'main' into fix_stage_name_handling
rddimon 90a5d4f
AT-9828: Update CHANGELOG.md and version
rddimon c7c0809
AT-9828: small improvements
rddimon 83cdb9e
AT-9828: update packages
rddimon 18f9ccf
AT-9828: revert debug test config
rddimon 705f355
AT-9828: Add retry strategy and fix integration test
rddimon 2c10e89
AT-9828: update packages and release date
rddimon 0ed253f
AT-9828: fix warning message
rddimon 4a8ab9c
AT-9828: fix http-api test
rddimon 3010bea
AT-9828: move warning to the right place
rddimon f9554b7
AT-9828: fix unit tests
rddimon 214c4ea
AT-9828: update warning message
rddimon 3d39641
AT-9828: pr review fixes
rddimon c9329ba
AT-9828: pr review fixes
rddimon f717abd
AT-9828: fix message
rddimon 644ff83
AT-9828: fix test
rddimon 9877e31
AT-9828: update retry strategy
rddimon e16880f
AT-9828: remove unused code
rddimon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,11 +27,13 @@ custom: | |
basePath: '' | ||
endpointType: REGIONAL | ||
autoDomain: true | ||
stage: '$default' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this required now? This could be considered a breaking change. Is it possible to default to |
||
- http: | ||
domainName: ${env:PLUGIN_IDENTIFIER}-http-api-milti2-${env:RANDOM_STRING}.${env:TEST_DOMAIN} | ||
basePath: '' | ||
endpointType: REGIONAL | ||
autoDomain: true | ||
stage: '$default' | ||
|
||
package: | ||
patterns: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm what are people supposed to do when they see this warning?