-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stage name handling #579
Conversation
src/index.ts
Outdated
@@ -365,6 +365,12 @@ class ServerlessCustomDomain { | |||
domain.domainInfo = await apiGateway.getCustomDomain(domain); | |||
|
|||
if (!domain.apiMapping) { | |||
if (domain.apiType === Globals.apiTypes.http) { | |||
Logging.logWarning( | |||
"Make sure that the API Mapping with the `$default` stage already exists. " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm what are people supposed to do when they see this warning?
@@ -27,11 +27,13 @@ custom: | |||
basePath: '' | |||
endpointType: REGIONAL | |||
autoDomain: true | |||
stage: '$default' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required now? This could be considered a breaking change. Is it possible to default to $default
for http APIs?
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixes #578
Description of Issue Fixed
Changes proposed in this pull request:
retryStrategy
for the APiGateway clients in caseToManyRequests
error or such