-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit d3 dependencies? #1567
Comments
That makes sense. We'll add it in the next version. |
Fixed in 5.9.13. [5.9.13] - 2024-07-03Fixed
Make sure you clear your browser cache after upgrading. And feel free to contact us again if you are still experiencing this issue. |
Hi @martynasma! I'm not seeing these packages in the 5.9.13 package.json on main: Am I missing something? It doesn't seem like this would fix the issue without that change. |
@JackRobards Sorry about that, we forgot to include the changes in 5.9.13, so they'll be in 5.9.14 instead. |
Fixed in 5.10.0. [5.10.0] - 2024-07-22Added
Fixed
Make sure you clear your browser cache after upgrading. And feel free to contact us again if you are still experiencing this issue. |
Question
Would it be possible to add explicit
d3-shape
,d3-force
, andd3-hierarchy
dependencies to the package.json file for amCharts5?From what I can tell, all of these are already used in the repository and pulled in via other d3 dependencies. These 3 packages are directly imported and used in a few places in the codebase (e.g. here). Also,
d3-shape
andd3-hierarchy
are already including@types
packages in the package.json as well, just not the packages themselves.I ran into an issue with a bundler where it complains that these packages aren't directly included. I can ignore it or patch the package.json on my side, but it would be nice if it could be updated in the root project unless you all have a strong reason you'd prefer not to.
Environment (if applicable)
Latest amCharts@5 version.
Also using TypeScript, Vite, and ESM.
Additional context
I believe the error is related to #1265 (and some of the other related issues) but adding these 3 explicit dependencies should help in my case and would be simpler than fully implementing ESM for the project. Since the dependencies are directly used, adding them to the package.json would be a good idea in opinion at least!
The text was updated successfully, but these errors were encountered: