Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak when removing indicator #1602

Closed
1412578 opened this issue Jul 4, 2024 · 1 comment
Closed

Memory leak when removing indicator #1602

1412578 opened this issue Jul 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@1412578
Copy link

1412578 commented Jul 4, 2024

ChartIndicator.js
image

When removing the indicator, I noticed that there was no handling to remove the event handler. Consequently, the Indicator class remains retained through the 'this' reference.

@martynasma martynasma added bug Something isn't working in next release Implemented. Available soon. labels Jul 4, 2024
@martynasma
Copy link
Collaborator

Fixed in 5.10.0.

[5.10.0] - 2024-07-22

Added

  • A second parameter (dataContext) added to Component's methods pushDataItem and makeDataItem, allowing to pass in a data context object related to the data item.
  • New class PatternSet added. Allows serving patterns similarly to ColorSet. More info.
  • New setting patterns added to Hierarchy, PercentSeries, Venn, SerialChart, FlowNodes. More info.
  • New setting fillPattern added to IFlowNodesDataItem, IHierarchyDataItem, IPercentSeriesDataItem, IVennDataItem, ISeriesSettings.

Fixed

  • LinkedHierarchy nodes were not clickable when children were added using addChildData() method.
  • If there were no nodes at topLevel in Hierarchy chart, it would show nodes from upper levels.
  • Not all event listeners were disposed when disposing a ChartIndicator. This could cause a memory leak.
  • Sprite's hover()/unhover() methods now check if the Sprite is not disposed. This fixes some potential errors when disposed items are being referenced.
  • Adding in explicit d3 dependencies (Issue 1567)
  • DurationFormatter was not rounding fractional numbers properly in some cases.

Full change log.

Download options.

Make sure you clear your browser cache after upgrading. And feel free to contact us again if you are still experiencing this issue.

@martynasma martynasma removed the in next release Implemented. Available soon. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants