Improve contrast of links when focused #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfthinker
reviewed
Jan 30, 2017
| @@ -60,6 +60,11 @@ a:focus { | |||
| outline: 3px solid $focus-colour; | |||
| } | |||
|
|
|||
| /* Make links slightly darker when focused to improve contrast. */ | |||
| a:link:focus { | |||
There was a problem hiding this comment.
What should be the colour when the link is visited? If there is nothing overwriting that, visited links will probably still show the lighter blue.
There was a problem hiding this comment.
I'm not proposing changing the visited colour when focused. It will stay as purple - which meets our contrast requirements.
|
I’m happy with the first commit in this PR. The second one seems to be a dupe of #274? This should either be revised to remove the second commit, or the other PR closed (and the suggestions in it applied here). |
gemmaleigh
force-pushed
the
focus-link-colour
branch
from
b1db73d
to
73cf50c
Compare
|
@robinwhittleton @edwardhorsford I've amended this PR, so it now only makes the one change - to make link text slightly darker when focused. |
|
I've updated the text of the PR to reduce the scope of what it covers. |
robinwhittleton
pushed a commit
that referenced
this pull request
Mar 16, 2017
- Fix EJS template (PR #270) - Add `theme-color` support to make the page surround in Chrome’s tab view on Android match the black GOV.UK header (PR #278) - Add `text-decoration-skip: ink` to all links on GOV.UK (PR #281) - Improve contrast of links when focused (PR #272) - Make header text colour black when focused (PR #274)
Merged
robinwhittleton
pushed a commit
that referenced
this pull request
Mar 29, 2017
- Fix EJS template (PR #270) - Add `theme-color` support to make the page surround in Chrome’s tab view on Android match the black GOV.UK header (PR #278) - Add `text-decoration-skip: ink` to all links on GOV.UK (PR #281) - Improve contrast of links when focused (PR #272) - Make header text colour black when focused (PR #274)
robinwhittleton
pushed a commit
that referenced
this pull request
Mar 29, 2017
- Fix EJS template (PR #270) - Add `theme-color` support to make the page surround in Chrome’s tab view on Android match the black GOV.UK header (PR #278) - Add `text-decoration-skip: ink` to all links on GOV.UK (PR #281) - Improve contrast of links when focused (PR #272) - Make header text colour black when focused (PR #274)
fofr
pushed a commit
to alphagov/static
that referenced
this pull request
May 5, 2017
# 0.20.0 - Fix EJS template - PR #270 - alphagov/govuk_template#270 - Add `theme-color` support to make the page surround in Chrome’s tab view on Android match the black GOV.UK header - PR #278 - alphagov/govuk_template#278 - Add `text-decoration-skip: ink` to all links on GOV.UK - PR #281 - alphagov/govuk_template#281 - Improve contrast of links when focused - PR #272 - alphagov/govuk_template#272 - Make header text colour black when focused - PR #274 - alphagov/govuk_template#274 # 0.19.2 - Increase skiplink colour contrast - PR #263 - alphagov/govuk_template#263 - Fix Scala compile issues for Play template - PR #261 - alphagov/govuk_template#261 # 0.19.1 - Have focus outline appear outside of element rather than covering it in Safari and Chrome - PR #259 - alphagov/govuk_template#259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
Note - I've not tested this with template itself, but the sass itself seems to work.
Before:
After: